💄 Allow passing icon props to IconButton#1288
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates IconButton to support forwarding selected props to the underlying EDS Icon, enabling customization (e.g., size, title, color) without changing the IconButton API surface significantly.
Changes:
- Added an
iconPropsprop toIconButton(typed asOmit<IconProps, 'data'>) and spread it onto the rendered<Icon />. - Bumped package version from
13.1.1to13.1.2.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/molecules/Button/IconButton/IconButton.tsx | Adds iconProps passthrough to customize the internal EDS Icon. |
| package.json | Version bump for the release containing the new optional prop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IconButtoncomponent, allowing consumers to pass additional props to the underlyingIconvia a newiconPropsprop. This increases flexibility for customizing the icon's appearance or behavior.