Skip to content

feat: improve no items found styling#1298

Open
benjamin-lyon wants to merge 6 commits into
mainfrom
feat/improve-no-items-found-styling
Open

feat: improve no items found styling#1298
benjamin-lyon wants to merge 6 commits into
mainfrom
feat/improve-no-items-found-styling

Conversation

@benjamin-lyon

@benjamin-lyon benjamin-lyon commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Jira links

User story


  • Needs to be tested locally by reviewer

Copilot AI review requested due to automatic review settings June 17, 2026 12:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the visual presentation of the Select “No items found” state by giving it consistent spacing and a stable row height, aligning it more closely with normal menu item layout to reduce layout shift.

Changes:

  • Updated NoItemsFoundText styling to use flex alignment and padding.
  • Added a min-height to match a single menu row height and avoid visual jumpiness.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 100% (🎯 100%) 17437 / 17437
🔵 Statements 100% (🎯 100%) 17437 / 17437
🔵 Functions 100% (🎯 100%) 1278 / 1278
🔵 Branches 100% (🎯 100%) 4445 / 4445
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/molecules/Select/GroupedSelectPersistent.tsx 100% 100% 100% 100%
src/molecules/Select/ListSelectPersistent.tsx 100% 100% 100% 100%
src/molecules/Select/Select.styles.ts 100% 100% 100% 100%
Generated in workflow #2371 for commit aaa76de by the Vitest Coverage Report Action

@benjamin-lyon
benjamin-lyon marked this pull request as ready for review June 17, 2026 13:25
@benjamin-lyon
benjamin-lyon requested a review from a team as a code owner June 17, 2026 13:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread src/molecules/Select/Select.styles.ts
@benjamin-lyon benjamin-lyon changed the title Feat/improve no items found styling feat: improve no items found styling Jul 1, 2026
arkadiy93
arkadiy93 previously approved these changes Jul 7, 2026
Copilot AI review requested due to automatic review settings July 8, 2026 07:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread src/molecules/Select/Select.styles.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@benjamin-lyon
benjamin-lyon requested a review from arkadiy93 July 8, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants