Skip to content

feat: improve no items found styling #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benjamin-lyon wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: improve no items found styling #1298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c732c0a
style: improve NoItemsFound styling and remove test-only tag
benjamin-lyon Jun 16, 2026
33cd202
style: enhance NoItemsFoundText styling to prevent layout shift
benjamin-lyon Jun 16, 2026
640e873
Merge branch 'main' into feat/improve-no-items-found-styling
benjamin-lyon Jun 17, 2026
bb26ccc
style: replace NoItemsFoundText with PersistentNoItemsFoundText to pr…
benjamin-lyon Jun 18, 2026
e336efc
Merge branch 'main' into feat/improve-no-items-found-styling
benjamin-lyon Jul 8, 2026
aaa76de
fix: update PERSISTENT_ITEM_HEIGHT calculation for consistent layout
benjamin-lyon Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/molecules/Select/GroupedSelectPersistent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import { SelectOptionRequired } from 'src/molecules';
import { useGroupedSelectItems } from 'src/molecules/Select/Select.hooks';
import {
GroupTitle,
NoItemsFoundText,
PersistentGroupsWrapper,
PersistentNoItemsFoundText,
} from 'src/molecules/Select/Select.styles';
import {
CustomMenuItemComponentProps,
Expand Down Expand Up @@ -38,7 +38,7 @@ export const GroupedSelectPersistent = <T extends SelectOptionRequired>(
const { filteredGroups, filteredGroupSum } = useGroupedSelectItems(props);

if (filteredGroups.length === 0) {
return <NoItemsFoundText>No items found</NoItemsFoundText>;
return <PersistentNoItemsFoundText>No items found</PersistentNoItemsFoundText>;
}

// This case never happens, since there is a check in select.tsx. This check gives the correct typescript inference.
Expand Down
6 changes: 4 additions & 2 deletions src/molecules/Select/ListSelectPersistent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { capitalize } from 'src/atoms';
import { useListSelectItems } from 'src/molecules/Select/Select.hooks';
import {
GroupTitle,
NoItemsFoundText,
NoTagFoundText,
PersistentNoItemsFoundText,
} from 'src/molecules/Select/Select.styles';
import {
CustomMenuItemComponentProps,
Expand Down Expand Up @@ -40,7 +40,9 @@ export const ListSelectPersistent = <T extends SelectOptionRequired>(
const { filteredItems } = useListSelectItems(props);

if (filteredItems.length === 0 && (!props.onAddItem || search === '')) {
return <NoItemsFoundText>No items found</NoItemsFoundText>;
return (
<PersistentNoItemsFoundText>No items found</PersistentNoItemsFoundText>
);
}

const hasNestedItems = filteredItems.some(
Expand Down
20 changes: 18 additions & 2 deletions src/molecules/Select/Select.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ import { Chip } from 'src/molecules/Chip/Chip';

import styled, { css } from 'styled-components';

// Persistent mode keeps an explicit item height so the empty state matches without layout shift
const PERSISTENT_ITEM_HEIGHT = `calc(${spacings.medium} * 2 + 24px)`; // 2×spacings.medium padding + 24px line-height

interface WrapperProps {
$showBackgroundColor: boolean;
}
Expand Down Expand Up @@ -336,6 +339,7 @@ const PersistentListItem = styled.button`
padding: ${spacings.medium} ${spacings.medium};
justify-content: flex-start;
gap: ${spacings.small};
min-height: ${PERSISTENT_ITEM_HEIGHT};
box-sizing: border-box;
svg {
flex-shrink: 0;
Expand Down Expand Up @@ -382,8 +386,19 @@ const NoTagFoundText = styled(Typography)`
margin: ${spacings.medium};
`;

const NoItemsFoundText = styled(Typography)`
margin-left: ${spacings.medium};
const NoItemsFoundText = styled(Typography).attrs({
group: 'navigation',
variant: 'menu_title',
})`
display: flex;
align-items: center;
margin: 0;
padding: ${spacings.medium};
box-sizing: border-box;
`;

const PersistentNoItemsFoundText = styled(NoItemsFoundText)`
min-height: ${PERSISTENT_ITEM_HEIGHT};
`;

const StyledMenu = styled(EDSMenu)`
Expand Down Expand Up @@ -428,6 +443,7 @@ export {
StyledMenu,
NoTagFoundText,
NoItemsFoundText,
PersistentNoItemsFoundText,
PlaceholderText,
PersistentListItem,
PersistentComboBoxWrapper,
Expand Down
Loading