fix: toast colors#1307
Open
benjamin-lyon wants to merge 14 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Toast variant color handling to better control container/background, button/icon foreground/hover states, and the duration progress fill, aligning Toast visuals across variants.
Changes:
- Replaced the old
TOAST_COLORSshape with a more granular set of variant color tokens (container/control/progress). - Updated
Toastmarkup to use new styled subcomponents (Title,Description,HeaderIcon,ActionButton,CloseButton) for variant-driven styling. - Enhanced Storybook stories to better showcase duration behavior across variants and adjusted action button text.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/molecules/Toast/Toast.utils.ts | Updates the toast variant color token map to new keys for container/control/progress styling. |
| src/molecules/Toast/Toast.tsx | Switches Toast rendering to new styled subcomponents and wires variant props through. |
| src/molecules/Toast/Toast.styles.ts | Introduces new styled subcomponents and applies variant-aware styling for icon/button/progress bar. |
| src/molecules/Toast/Toast.stories.tsx | Updates stories to render duration across all variants and tweaks action labeling. |
Comments suppressed due to low confidence (1)
src/molecules/Toast/Toast.tsx:114
- Elements with
role="progressbar"should have an accessible name (e.g.aria-labeloraria-describedby). Adding anaria-labelprevents screen readers from announcing an unnamed progress bar.
<DurationBar
role="progressbar"
$variant={variant}
$duration={duration}
/>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira links
User story