Make config required arg in ert_api_parser#13685
Draft
jaakson wants to merge 1 commit into
Draft
Conversation
Open
9 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13685 +/- ##
==========================================
+ Coverage 89.38% 89.91% +0.52%
==========================================
Files 469 468 -1
Lines 33391 33403 +12
==========================================
+ Hits 29847 30034 +187
+ Misses 3544 3369 -175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
|
You can consider adding a test in test_cli.py Possibly pick up output using; |
Move optional config argument from add_parser_options to parse_args Add test for API CLI error when config argument is missing
25206e7 to
82d59a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ert api subparser was being passed to an
add_parser_optionsfunction that addedconfigas an optional argument when it should be required.Issue
Resolves #13602
Approach
Dropped
configfromadd_parser_optionsMoved the optional config arg addition where it was needed
Added required config to
ert_api_parserthe way it's done for other subparsersPR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (
git rebase -i main --exec 'just rapid-tests')When applicable