Skip to content

Commit 58df78b

Browse files
54887 update token (#37)
* stop updating the bearer token when added automatically * refactoring to encapsulate bearer pre-processing
1 parent bcb479f commit 58df78b

1 file changed

Lines changed: 22 additions & 31 deletions

File tree

src/sumo/wrapper/_call_azure_api.py

Lines changed: 22 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,15 @@ def _is_token_expired(self):
7272
"""
7373
return self.auth.is_token_expired()
7474

75+
def _process_token(self, bearer):
76+
if bearer:
77+
return "Bearer " + bearer
78+
79+
if self._is_token_expired():
80+
self._generate_bearer_token()
81+
82+
return self.bearer
83+
7584
def get_json(self, url, bearer=None):
7685
"""
7786
Send an request to the url.
@@ -85,14 +94,11 @@ def get_json(self, url, bearer=None):
8594
Return
8695
json:
8796
The json respond from the entered URL
88-
"""
89-
if bearer is not None:
90-
self.bearer = "Bearer " + bearer
91-
elif self._is_token_expired():
92-
self._generate_bearer_token()
97+
"""
98+
bearer = self._process_token(bearer)
9399

94100
headers = {"Content-Type": "application/json",
95-
"Authorization": self.bearer}
101+
"Authorization": bearer}
96102

97103
response = requests.get(url, headers=headers)
98104

@@ -115,13 +121,10 @@ def get_image(self, url, bearer=None):
115121
image:
116122
raw image
117123
"""
118-
if bearer is not None:
119-
self.bearer = "Bearer " + bearer
120-
elif self._is_token_expired():
121-
self._generate_bearer_token()
124+
bearer = self._process_token(bearer)
122125

123126
headers = {"Content-Type": "html/text",
124-
"Authorization": self.bearer}
127+
"Authorization": bearer}
125128

126129
response = requests.get(url, headers=headers, stream=True)
127130

@@ -144,13 +147,10 @@ def get_content(self, url, bearer=None):
144147
content:
145148
The content respond from the entered URL.
146149
"""
147-
if bearer is not None:
148-
self.bearer = "Bearer " + bearer
149-
elif self._is_token_expired():
150-
self._generate_bearer_token()
150+
bearer = self._process_token(bearer)
151151

152152
headers = {"Content-Type": "application/json",
153-
"Authorization": self.bearer}
153+
"Authorization": bearer}
154154

155155
response = requests.get(url, headers=headers)
156156

@@ -172,16 +172,13 @@ def post(self, url, blob=None, json=None, bearer=None):
172172
Return
173173
string: The string respond from the entered URL
174174
"""
175-
if bearer is not None:
176-
self.bearer = "Bearer " + bearer
177-
elif self._is_token_expired():
178-
self._generate_bearer_token()
175+
bearer = self._process_token(bearer)
179176

180177
if blob and json:
181178
raise ValueError('Both blob and json given to post - can only have one at the time.')
182179

183180
headers = {"Content-Type": "application/json" if json is not None else "application/octet-stream",
184-
"Authorization": self.bearer,
181+
"Authorization": bearer,
185182
"Content-Length": str(len(json) if json else len(blob)),
186183
}
187184

@@ -205,10 +202,7 @@ def put(self, url, blob=None, json=None, bearer=None):
205202
Return
206203
string: The string respond from the entered URL
207204
"""
208-
if bearer is not None:
209-
self.bearer = "Bearer " + bearer
210-
elif self._is_token_expired():
211-
self._generate_bearer_token()
205+
bearer = self._process_token(bearer)
212206

213207
if blob and json:
214208
raise ValueError('Both blob and json given to put - can only have one at the time.')
@@ -219,7 +213,7 @@ def put(self, url, blob=None, json=None, bearer=None):
219213
}
220214

221215
if url.find("sig=") < 0:
222-
headers["Authorization"] = self.bearer
216+
headers["Authorization"] = bearer
223217

224218
response = requests.put(url, data=blob, json=json, headers=headers)
225219

@@ -239,13 +233,10 @@ def delete_object(self, url, bearer=None):
239233
Return
240234
json: The json respond from the entered URL
241235
"""
242-
if bearer is not None:
243-
self.bearer = "Bearer " + bearer
244-
elif self._is_token_expired():
245-
self._generate_bearer_token()
236+
bearer = self._process_token(bearer)
246237

247238
headers = {"Content-Type": "application/json",
248-
"Authorization": self.bearer,
239+
"Authorization": bearer,
249240
}
250241

251242
response = requests.delete(url, headers=headers)

0 commit comments

Comments
 (0)