feat: Implement display popups

Author: mateocastano15

flutter-lib/lib/src/gen/display.dart

@@ -1,4 +1,5 @@
 import 'package:json_annotation/json_annotation.dart';
+import 'menu.dart';
 import 'shell.dart';
 
 part 'display.g.dart';
@@ -8,6 +9,7 @@ class VDisplay {
   String? swt;
   int? id;
   List<VShell>? shells;
+  List<VMenu>? popups;
 
   VDisplay();
 

flutter-lib/lib/src/gen/display.g.dart

@@ -104,6 +104,8 @@ class _DisplaySwtState extends State<DisplaySwt> {
 
       return Stack(children: [
         for (final s in mainShells) Positioned.fill(child: gen.mapWidgetFromValue(s)),
+        for (final popup in (_display.popups ?? []))
+          Positioned.fill(child: gen.mapWidgetFromValue(popup)),
         if (dialogShells.any(_isModal))
           Positioned.fill(
             child: ColoredBox(

flutter-lib/lib/src/impl/display_evolve.dart

@@ -884,6 +884,10 @@ public void setLocation(int x, int y) {
         this.x = x;
         this.y = y;
         hasLocation = true;
+        if (location == null || location.x != x || location.y != y) {
+            location = new Point(x, y);
+            dirty();
+        }
     }
 
     /**

swt_native/src/macos/java/org/eclipse/swt/widgets/DartMenu.java

@@ -25,7 +25,7 @@ static Point toDisplay(DartControl dartControl, int x, int y) {
         if (ancestor != null) {
             return ancestor.toDisplay(x + offset[0], y + offset[1]);
         }
-        return dartControl.display.map(dartControl.getApi(), null, x, y);
+        return new Point(x + offset[0], y + offset[1]);
     }
 
     static Point toControl(DartControl dartControl, int x, int y) {

swt_native/src/main/java/org/eclipse/swt/widgets/ControlHelper.java

@@ -488,6 +488,9 @@ void addPopup(Menu menu) {
             popups = newPopups;
         }
         popups[index] = menu;
+        if (displayBridge != null) {
+            displayBridge.sendDisplayUpdate(this);
+        }
     }
 
     void addSkinnableWidget(Widget widget) {
@@ -985,6 +988,20 @@ public static Display findDisplay(Thread thread) {
      */
     public Shell getActiveShell() {
         checkDevice();
+        Control focus = getFocusControl();
+        if (focus != null && !focus.isDisposed()) {
+            Shell shell = focus.getShell();
+            if (shell != null && !shell.isDisposed() && shell.getVisible()) {
+                return shell;
+            }
+        }
+        Shell[] currentShells = getShells();
+        for (int i = currentShells.length - 1; i >= 0; i--) {
+            Shell shell = currentShells[i];
+            if (shell != null && !shell.isDisposed() && shell.getVisible()) {
+                return shell;
+            }
+        }
         return null;
     }
 
@@ -2684,6 +2701,9 @@ void removePopup(Menu menu) {
         for (int i = 0; i < popups.length; i++) {
             if (popups[i] == menu) {
                 popups[i] = null;
+                if (displayBridge != null) {
+                    displayBridge.sendDisplayUpdate(this);
+                }
                 return;
             }
         }

swt_native/src/web/java/org/eclipse/swt/widgets/DartDisplay.java

@@ -884,6 +884,10 @@ public void setLocation(int x, int y) {
         this.x = x;
         this.y = y;
         hasLocation = true;
+        if (location == null || location.x != x || location.y != y) {
+            location = new Point(x, y);
+            dirty();
+        }
     }
 
     /**
@@ -968,6 +972,27 @@ public void setVisible(boolean visible) {
         checkWidget();
         if ((getApi().style & (SWT.BAR | SWT.DROP_DOWN)) != 0)
             return;
+        if (visible) {
+            if (!hasLocation) {
+                Point menuLocation = display.getCursorLocation();
+                if (menuLocation == null || (menuLocation.x == 0 && menuLocation.y == 0)) {
+                    Control owner = findOwnerControl();
+                    if (owner != null && !owner.isDisposed()) {
+                        Point ownerSize = owner.getSize();
+                        int yOffset = ownerSize != null ? ownerSize.y : 0;
+                        menuLocation = owner.toDisplay(0, yOffset);
+                    }
+                }
+                if (menuLocation != null) {
+                    x = menuLocation.x;
+                    y = menuLocation.y;
+                    location = menuLocation;
+                    hasLocation = true;
+                    dirty();
+                }
+            }
+            hasLocation = false;
+        }
         this.visible = newValue;
         if (visible) {
             ((DartDisplay) display.getImpl()).addPopup(this.getApi());

swt_native/src/web/java/org/eclipse/swt/widgets/DartMenu.java

@@ -13,6 +13,7 @@ public class VDisplay {
     public long id;
     public String swt;
     public Shell[] shells;
+    public Menu[] popups;
 
     protected VDisplay() {
     }
@@ -29,6 +30,16 @@ public static VDisplay of(DartDisplay display) {
             }
         }
         v.shells = visible.toArray(Shell[]::new);
+        Menu[] displayPopups = display.popups;
+        ArrayList<Menu> popupList = new ArrayList<>();
+        if (displayPopups != null) {
+            for (Menu menu : displayPopups) {
+                if (menu != null && !menu.isDisposed()) {
+                    popupList.add(menu);
+                }
+            }
+        }
+        v.popups = popupList.toArray(Menu[]::new);
         return v;
     }
 
@@ -66,6 +77,17 @@ public static void write(JsonWriter writer, VDisplay v) {
                 }
                 writer.writeByte((byte) ']');
             }
+            writer.writeAscii(",\"popups\":");
+            if (v.popups == null || v.popups.length == 0) {
+                writer.writeAscii("[]");
+            } else {
+                writer.writeByte((byte) '[');
+                for (int i = 0; i < v.popups.length; i++) {
+                    if (i > 0) writer.writeByte((byte) ',');
+                    VMenu.MenuJson.write(writer, v.popups[i]);
+                }
+                writer.writeByte((byte) ']');
+            }
             writer.writeByte((byte) '}');
         }
     }