Skip to content

Commit 149a1d5

Browse files
authored
fix: consistency in comments in IPluginExecutor interface and spec (#36)
1 parent a178bd4 commit 149a1d5

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

standard/ERCs/erc-6900.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -187,16 +187,18 @@ This prevents accidental misconfiguration or misuse of plugins (both installed a
187187
```solidity
188188
interface IPluginExecutor {
189189
/// @notice Execute a call from a plugin to another plugin, via an execution function installed on the account.
190-
/// @dev Permissions must be granted to the calling plugin for the call to go through.
191-
/// @param data Calldata to send to the plugin.
190+
/// @dev Plugins are not allowed to call native functions on the account. Permissions must be granted to the
191+
/// calling plugin for the call to go through.
192+
/// @param data The calldata to send to the plugin.
192193
/// @return The return data from the call.
193194
function executeFromPlugin(bytes calldata data) external payable returns (bytes memory);
194195
195196
/// @notice Execute a call from a plugin to a non-plugin address.
196-
/// @dev Permissions must be granted to the calling plugin for the call to go through.
197-
/// @param target Address of the target to call.
198-
/// @param value Value to send with the call.
199-
/// @param data Calldata to send to the target.
197+
/// @dev If the target is a plugin, the call SHOULD revert. Permissions must be granted to the calling plugin
198+
/// for the call to go through.
199+
/// @param target The address to be called.
200+
/// @param value The value to send with the call.
201+
/// @param data The calldata to send to the target.
200202
/// @return The return data from the call.
201203
function executeFromPluginExternal(address target, uint256 value, bytes calldata data)
202204
external

0 commit comments

Comments
 (0)