Skip to content

Pre upgrade#2

Open
ericnoam wants to merge 90 commits into
masterfrom
pre_upgrade
Open

Pre upgrade#2
ericnoam wants to merge 90 commits into
masterfrom
pre_upgrade

Conversation

@ericnoam
Copy link
Copy Markdown
Owner

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

KonstantinVishnivetskii and others added 30 commits May 18, 2023 15:40
* Values for PSQL database name, elastic prefix
---------

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
…#310)

* feat: Add ability to specify extraPodLabels per deployment

* Update Chart.yaml

---------

Co-authored-by: jorrick <jorrick.sleijster@adyen.com>
Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
* fix(datahub): use common labels for (Cron)Jobs

* chore: update version

---------

Co-authored-by: Matthijs van der Loos <matthijs.vanderloos@utopiamusic.com>
Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
* fix(datahub): add missing global values to subchart values

* chore: update versions

---------

Co-authored-by: Matthijs van der Loos <matthijs.vanderloos@utopiamusic.com>
Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
…ta#323)

* chore(secrets): use configurable refs instead of fixed names

* Update Chart.yaml

---------

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
Co-authored-by: Indy Prentice <indy@Indys-MacBook-Pro.local>
Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
…acryldata#315)

* allow for overriding hook annotations
* allow for specifying init containers on all jobs
---------
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
* feat(cron): Adding more parameters to ingestion-cron
---------

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
…ata#337)

* Update charts to include search and browse env variable flags
* fix(config) Set search and browse flags default off
acryldata#342)

* feat : add tolerations parameter in datahub-ingestion-cron chart

---------

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
* Helm update for 0.10.5 release

* use latest point release for ingestion
* docs(readme):  Add notes about randomized keys and credentials
* fix(auth-secret): remove auth secret from common template, cannot be used by all jobs
…REGISTER_SCHEMAS` (acryldata#358)

* fix(datahub-system-update-job): enable SPRING_KAFKA_PROPERTIES_AUTO_REGISTER_SCHEMAS
* feat(session): add session duration configuration
…ldata#356)

* fix: remove unused and irrelevant sidecar configuration
* fix: correct sidecar configuration in cron job template
* fix: update ingestion cron sidecar parameter in README

---------

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
Co-authored-by: Indy Prentice <indy@Indys-MacBook-Pro.local>
* feat(release): updates for release v0.11.0
* doc(values): remove duplicate doc

* Update Chart.yaml

---------

Co-authored-by: Pedro Silva <pedro@acryl.io>
gschuurman and others added 30 commits December 20, 2023 20:21
Fix Issue acryldata#414 where
only google OIDC Username claim and regexp were overridable. This was
incorrect, and should have never been the case, this is especially
important for azure since some Entra ID deployments do not specify email
addresses in the OIDC token.

Co-authored-by: Glenn Schuurman <glenn.schuurman@dataplatformgemeenten.nl>
…error loop (acryldata#417)

* feat(kafka): add configuration option for preventing deserialization error loop

* documentation

* fix lint
)

* feat(ingestion): add configuration option to suspend jobs

* Update chart version
* fix(release): bump chart versions

* bump master chart version
* fix: fix custom command & args behavior

Fix two issues with the custom command & args behavior
added in acryldata#408:

1. Change custom command & args to use `toRawJson` instead of
`toJson`.  Previously, this resulted in special character would
be escaped.

For example, this value:
```
args: [ "source setup.sh && /datahub/datahub-gms/scripts/start.sh" ]
```

Would get rendered as:

```
args: [ "source setup.sh \u0026\u0026 /datahub/datahub-gms/scripts/start.sh" ]
```

Use `toRawJson` to force special values to not be escaped

2. Add custom command & args to all other containers that do not
support it:
  - Datahub cleanup job
  - Datahub Nocode Migration Job
  - Datahub Restore Indices Job
  - Datahub System Update Job
  - Datahub Actions
  - Elastic Search Setup
  - Kafka Setup
  - Mysql Setup
  - Postgres setup

* fix lint issues

---------

Co-authored-by: Travis Cook <tcook@slack-corp.com>
* feat: add ingestion config map in values

Add support for providing the ingestion recipe's
definition in `datahub-ingestion-cron`'s `values.yaml`.

The current datahub helm implementation relies on an
externally managed config map to specify an ingestion
recipe.  This necessarily requires production k8s access
or a separate management system for k8s config maps.

Now, helm can manage the config map for datahub.

This is backwards compatible - if `fileContent` is not
provided, it assumes the config map is managed externally

* fix: improve some of the commented out examples in values.yaml

---------

Co-authored-by: Travis Cook <tcook@slack-corp.com>
…a#424)

* fix(ingestion): Fix scope of `.Values.globals` in ingestion

Because we're in a `range` inside `datahub-ingestion-cron`,
we can't access global values via `{{ .Values.global...`
Instead, we need `{{ $.Values...`.  Otherwise, we get
an error:

```
Error: template: datahub/charts/datahub-ingestion-cron/templates/cron.yaml:78:34: executing "datahub/charts/datahub-ingestion-cron/templates/cron.yaml" at <.Values.global.nodeSelector>: nil pointer evaluating interface {}.global
helm.go:84: [debug] template: datahub/charts/datahub-ingestion-cron/templates/cron.yaml:78:34: executing "datahub/charts/datahub-ingestion-cron/templates/cron.yaml" at <.Values.global.nodeSelector>: nil pointer evaluating interface {}.global
```

Fix so that it uses globals or the cron specific `nodeSelector`
and `tolerations` instead of triggering a nil pointer error

* bump global chart version

---------

Co-authored-by: Travis Cook <tcook@slack-corp.com>
api version should be `v1` for configmap
objects, not `batch/v1`.

Co-authored-by: Travis Cook <tcook@slack-corp.com>
…cryldata#429)

* adding custom labels to the datahub-frontend service

* Update README.md

* bumping the version in the parent chart

* bumping the datahub chart version
* add logic to split system-update into blocking and nonblocking steps
* Bump kafka chart to 26.11.2, which uses kafka 3.6.1
* Override default broker.minId
* feat(release): v0.13.0

* enabled nonblocking

* fix lint
* bump bitnami mysql chart and repo
* docs: Updated mysql secret generation command

By the change of mysql helm chart version the provided secret
has at least three keys:
- mysql-root-password
- mysql-replication-password
- mysql-password

Otherwise mysql chart won't install.
More information: https://artifacthub.io/packages/helm/bitnami/mysql#mysql-common-parameters

* fix: Applied requested changes
* fix(system-update): extraEnvs indent
* fix: hazelcast service name
* chart versions
* fix(system-update): really fix indent this time
* adjust nonblocking annotations
* feat(restoreIndices): configurable crontab schedule

* and set default schedule to once per week on Sunday

* chore: bump chart version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.