execution: remove BadHashes (#17733)

See ethereum/go-ethereum#29609

Author: yperbasis

execution/core/blocks.go

@@ -29,9 +29,6 @@ var (
 	// ErrKnownBlock is returned when a block to import is already known locally.
 	ErrKnownBlock = errors.New("block already known")
 
-	// ErrBlacklistedHash is returned if a block to import is on the blacklist.
-	ErrBlacklistedHash = errors.New("blacklisted hash")
-
 	// ErrNoGenesis is returned when there is no Genesis Block.
 	ErrNoGenesis = errors.New("genesis not found in chain")
 

execution/core/error.go

@@ -22,7 +22,6 @@ package stages_test
 import (
 	"context"
 	"encoding/binary"
-	"errors"
 	"fmt"
 	"maps"
 	"math"
@@ -425,28 +424,6 @@ func testReorg(t *testing.T, first, second []int64, td int64) {
 	}
 }
 
-// Tests that the insertion functions detect banned hashes.
-func TestBadBlockHashes(t *testing.T) { testBadHashes(t) }
-
-func testBadHashes(t *testing.T) {
-	t.Parallel()
-	t.Skip("to support this error in Erigon")
-	// Create a pristine chain and database
-	m := newCanonical(t, 0)
-	var err error
-
-	// Create a chain, ban a hash and try to import
-	chain := makeBlockChain(current(m, nil), 3, m, 10)
-
-	core.BadHashes[chain.Headers[2].Hash()] = true
-	defer func() { delete(core.BadHashes, chain.Headers[2].Hash()) }()
-
-	err = m.InsertChain(chain)
-	if !errors.Is(err, core.ErrBlacklistedHash) {
-		t.Errorf("error mismatch: have: %v, want: %v", err, core.ErrBlacklistedHash)
-	}
-}
-
 // Tests that chain reorganisations handle transaction removals and reinsertions.
 func TestChainTxReorgs(t *testing.T) {
 	if testing.Short() {