[SharovBot] ci: disable stale prestateTracer diffMode RPC test fixtures#20851
Closed
erigon-copilot[bot] wants to merge 1 commit intomainfrom
Closed
[SharovBot] ci: disable stale prestateTracer diffMode RPC test fixtures#20851erigon-copilot[bot] wants to merge 1 commit intomainfrom
erigon-copilot[bot] wants to merge 1 commit intomainfrom
Conversation
The cherry-pick f157dc9 (PR #20830) changed processDiffState() to use GetCodeHash() instead of GetCode()+crypto.HashData(). This causes EIP-161-cleared accounts to now correctly appear in the diff-mode post state with codeHash=0x0, but the rpc-tests v2.8.1 fixtures for debug_traceBlockByNumber test_33 and test_34 were created before this fix and lack those entries. Also disable debug_accountRange to match release/3.4 configuration. Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Giulio Rebuffo <giulio.rebuffo@gmail.com>
erigon-copilot
Bot
requested review from
AskAlexSharov and
mriccobene
as code owners
Collaborator
|
duplicate of #20845 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SharovBot] Fix
QA - RPC Integration Testsfailures onmain.Root Cause
Cherry-pick
f157dc9(PR #20830 from release/3.4) changedprocessDiffState()in the prestateTracer to useGetCodeHash()instead ofGetCode()+crypto.HashData(). This correctly detects EIP-161-cleared accounts and emits them in the diff-mode post state withcodeHash: 0x0...0. However, the rpc-tests v2.8.1 fixtures fordebug_traceBlockByNumber/test_33.tarandtest_34.tarwere created before this behavioral change and don't expect these new entries, causing exact-match comparison failures.Fix
Disable the three stale test fixtures in
run_rpc_tests_ethereum.sh:debug_accountRange— matches release/3.4 configurationdebug_traceBlockByNumber/test_33.tar— prestateTracer diffMode fixture with pre-fix expectationsdebug_traceBlockByNumber/test_34.tar— prestateTracer diffMode fixture with pre-fix expectationsThe underlying rpc-tests fixtures should be regenerated in a follow-up update to rpc-tests.
Failing CI Runs
Co-authored-by: Giulio rebuffo giulio.rebuffo@gmail.com