[bal-devnet-3] p2p, txpool: fix Hive eth devp2p test failures (#20733)#20879
Open
mh0lt wants to merge 1 commit intobal-devnet-3from
Open
[bal-devnet-3] p2p, txpool: fix Hive eth devp2p test failures (#20733)#20879mh0lt wants to merge 1 commit intobal-devnet-3from
mh0lt wants to merge 1 commit intobal-devnet-3from
Conversation
## Summary Addresses 6 failures in the Hive `eth` devp2p simulator suite against erigon 3.5.0-dev ([run link](https://hive.ethpandaops.io/#/test/generic/1776841357-2075acc44b3e6ba92211e38c25fcc59c)). | Test | Root cause | Fix | |---|---|---| | `GetBlockHeaders` / `SimultaneousRequests` | Hash-mode forward traversal read the header at `query.Origin.Number` (the *current* block) instead of `next`, so the ancestor check always failed and responses were truncated to a single header. | `p2p/protocols/eth/handlers.go` — one-character change (`query.Origin.Number` → `next`), matches go-ethereum. | | `BlockRangeUpdateInvalid` | `blockRange69` returned a `Validate()` error, but `HandleInboundMessage` only kicks for RLP errors. | `sentry_multi_client.go` — explicit `PenalizePeer(Kick)` when `Earliest > Latest` or `LatestHash` is zero. | | `TestBlobTxWithMismatchedSidecar` | Blob-wrapper parser checked counts but not `KZGToVersionedHash(commitment[i]) == versioned_hash[i]`. The async pool `validateTx` catches it later, but the peer association is gone by then. | `fetch.go` — new `checkBlobSidecar` invoked on both `TRANSACTIONS_66` and `POOLED_TRANSACTIONS_66` while the peer is still known. | | `TestBlobViolations` | eth/68 `NewPooledTransactionHashes` carries per-hash (type, size), but the fetcher discarded both. Additionally, a same-bytes cross-peer dedup in the fetch loop prevented the tx-fetcher from falling back to a second announcer after the first was kicked. | `fetch.go` — a 64k-entry peer-stamped LRU records announcements for hashes that survive `FilterKnownIdHashes`; a one-shot check on `POOLED_TRANSACTIONS_66` kicks a peer whose delivered tx contradicts its own earlier announcement (type strict; size tolerates an 8-byte slack matching go-ethereum's inline `txSizeSlack` threshold in `eth/fetcher/tx_fetcher.go`). The pre-existing `seenLRU` dedup is now scoped to `TRANSACTIONS_66`/`POOLED_TRANSACTIONS_66` only, so announcements from alternative peers are no longer dropped. | | `client launch` | Suite-level rollup. | Passes once the above do. | CI wiring (`.github/workflows/test-hive.yml`): - Adds `devp2p/eth` as a matrix entry with `max-allowed-failures: 0` — the regression guard for the wire-protocol fixes above. The sibling devp2p suites (snap, discv4, discv5) are intentionally excluded; they have unrelated pre-existing failures. - Merges `engine-exchange-capabilities` and `engine-auth` into a single shard to free a queue slot on the capacity-limited `hive` runner group. - Passes the full sim path (`ethereum/engine`, `devp2p`, …) instead of hard-coding an `ethereum/` prefix, so non-`ethereum/` simulators resolve correctly. --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mh0lt
requested review from
AskAlexSharov,
anacrolix,
mriccobene,
taratorio and
yperbasis
as code owners
yperbasis
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #20733 onto bal-devnet-3. Required by the eth/71 cherry-pick stack: PR #20794 includes a regression test (
TestAnswerGetBlockHeadersQuery_HashModeSkip) that depends on the one-line forward-traversal fix in this PR.