add ReceiptRoot integrity check#20902
Merged
AskAlexSharov merged 10 commits intomainfrom Apr 30, 2026
Merged
Conversation
Adds a new integrity check that reads receipts from RCache domain, computes the receipt root via DeriveSha, and compares it with block.header.ReceiptHash. This is similar to StateRootVerifyByHistory but for receipt roots instead of state roots. Closes #19421
Open one ReceiptCacheV2Stream per chunk and call txNumsReader.Min once, instead of doing both per block. Walk the stream cursor and verify each block's receipt root when txNum crosses the block boundary. On a 140k-block hoodi sample this is ~40x faster (168s -> 4s, single-threaded).
ReceiptForStorage omits Bloom on disk; DeriveSha depends on it, so the integrity check produced a wrong root for any block with logs (e.g. mainnet 50303). Recompute Bloom per receipt before appending.
Diagnostic logging for the still-failing pre-fix mismatches: dumps per-receipt fields (type, status, postStateLen, cumGas, numLogs, bloomZero) when computed root differs from header.
Temporary: skip parallelChunkCheck and only verify block 49401 to isolate the receipt-root mismatch with focused per-receipt logging.
EIP-658 changed the consensus receipt encoding at Byzantium (mainnet 4,370,000): pre-Byzantium receipts contain a 32-byte PostState (intermediate state root); post-Byzantium receipts contain a 1-byte status. MakeReceipt only sets Status, so RCache cannot reconstruct the PostState, and the canonical receipt root is unrecoverable for pre-Byzantium blocks. Start the check at ByzantiumBlock instead.
sudeepdino008
requested review from
AskAlexSharov and
Giulio2002
as code owners
AskAlexSharov
approved these changes
Apr 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.