rpc fix streaming trace methods returning result:null in case of error#21922
Merged
Conversation
…ide error Remove stream.WriteNil() from early error paths in traceBlock, TraceTransaction, and traceCallMany. With the resultFieldStream wrapper introduced in #19267, writing nil to the stream before returning an error marks rs.written=true and forces "result":null into the response alongside the error — violating JSON-RPC 2.0 section 5 (result MUST NOT exist when error is present). Add TestTraceErrorPathsWriteNoStream to verify the stream buffer stays empty on early error returns.
lupin012
requested review from
lystopad,
mriccobene and
yperbasis
as code owners
AskAlexSharov
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove stream.WriteNil() from early error paths in traceBlock, TraceTransaction, and traceCallMany. With the resultFieldStream wrapper introduced in #19267, writing nil to the stream before returning an error marks rs.written=true and forces "result":null into the response alongside the error — violating JSON-RPC 2.0 section 5 (result MUST NOT exist when error is present).
Add TestTraceErrorPathsWriteNoStream to verify the stream buffer stays empty on early error returns.
To fix hive rpc-compact: