db/state: bound commitmentValTransformDomain key caches#21929
Merged
Conversation
The per-merge findShortenedKey caches added in #21303 had no size bound: on a whole-state commitment merge they grow one entry per distinct account/storage key, reaching multiple GB (a heap profile showed 4.3GB live in the replacer closure). Clear each cache when it exceeds keyCacheMaxEntries (4M) so memory stays bounded while hot recurring keys are still cached.
Giulio2002
approved these changes
Jun 21, 2026
Giulio2002
left a comment
Giulio2002
left a comment
Contributor
There was a problem hiding this comment.
LGTM — bounds the temporary key caches to avoid unbounded growth during a merge without changing the lookup behavior.
Giulio2002
approved these changes
Jun 22, 2026
Giulio2002
left a comment
Giulio2002
left a comment
Contributor
There was a problem hiding this comment.
LGTM — obvious safety bound on per-merge key caches to prevent unbounded growth.
Giulio2002
approved these changes
Jun 22, 2026
Giulio2002
left a comment
Giulio2002
left a comment
Contributor
There was a problem hiding this comment.
LGTM — simple, obviously safe bound on per-merge key caches to avoid unbounded growth.
JkLondon
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-merge
findShortenedKeycaches added in #21303 (storageKeyCache/accountKeyCacheincommitmentValTransformDomain) have no size bound. Onwith-deref-filesmerge - it acts as mem-leak.