mainnet/debug_traceBlockByNumber: refresh test_33/test_34 for prestateTracer deleted-accounts fix#554
Open
mainnet/debug_traceBlockByNumber: refresh test_33/test_34 for prestateTracer deleted-accounts fix#554
Conversation
…d for prestateTracer deleted-account fix erigontech/erigon#20775 fixed prestateTracer diff mode to include deleted accounts in the post state (with zeroed codeHash) — they were previously missing from the post block, which was the bug. Two mainnet integration fixtures hit blocks where this matters: - test_33 (block 0x1048428): result[133].post now includes 0xde587bd175be0875fadf15ea5c7bc488b7dd6484 - test_34: result[219].post now includes 0xf8b9495cc154569f6cc3395d47b03b95a86202d9 Each entry is the deleted account's stub: {"codeHash": "0x000…000"}. Without this update, mainnet-rpc-integ-tests is red on every PR (and on main itself) since the cherry-pick of erigon#20775 landed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
Sahil-4555
pushed a commit
to Sahil-4555/erigon
that referenced
this pull request
Apr 28, 2026
…tateTracer fix (erigontech#20845) ## Why erigontech#20775 (cherry-picked into main via erigontech#20830) fixed \`prestateTracer\` diff mode to include deleted accounts in the \`post\` state — they were silently missing before, which was the actual bug. Two mainnet rpc-tests fixtures hit blocks where this matters: - \`debug_traceBlockByNumber/test_33.tar\` — block \`0x1048428\`, deleted account \`0xde587bd175be0875fadf15ea5c7bc488b7dd6484\` - \`debug_traceBlockByNumber/test_34.tar\` — deleted account \`0xf8b9495cc154569f6cc3395d47b03b95a86202d9\` Their expected JSON in rpc-tests \`v2.8.1\` doesn't include those entries, so \`mainnet-rpc-integ-tests\` is red on every PR — including \`main\` itself since the cherry-pick landed. ## What Two-line addition to the \`DISABLED_TEST_LIST\` in \`run_rpc_tests_ethereum.sh\`. No production-code change. ## Follow-up Proper fix in flight: [erigontech/rpc-tests#554](erigontech/rpc-tests#554) refreshes the expected JSON for both blocks. Once that merges and a new tag (\`v2.8.2\`+) is cut, this workaround should be reverted and the version bumped in \`run_rpc_tests_ethereum.sh\` (and the matching cache keys in the qa workflows). ## Test plan - [x] CI run on this PR shows \`mainnet-rpc-integ-tests\` green again. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
erigontech/erigon#20775 fixed `prestateTracer` diff mode to include deleted accounts in the post state — they were previously missing from `post`, which was the actual bug. The fix landed on `main` via the cherry-pick batch #20830.
Since that merged, `mainnet-rpc-integ-tests` has been red on every PR and on `main` itself. Two of our mainnet fixtures hit blocks with deleted accounts and need their expected output refreshed.
What
Two single-key additions, each a deleted account's stub `{"codeHash": "0x0…0"}`:
Generated by extracting the actual response from the failing CI run, surgically inserting only the missing entry, and repacking the bz2-compressed `.tar`. Diff against the pristine fixture is one closing-brace comma + the three lines of the new entry, nothing else.
Verify
Once merged, the next `mainnet-rpc-integ-tests` run on `main` should go green again, unblocking erigontech/erigon#20795 and any other PR currently failing on these two tests.