Feature/allow application intent read only#302
Merged
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom Apr 29, 2026
Merged
Conversation
…dable replicas - including Query Store on secondary replicas) Fixes erikdarlingdata#301
Owner
|
Thanks for the contribution, @ClaudioESSilva! Clean implementation — merged. Doing a small round of cleanup follow-up now (the duplicated connection-string builder, label wording, and a couple of style nits I called out in the review). Will land as a separate PR so the credit on this feature stays with you. |
6 tasks
erikdarlingdata
added a commit
that referenced
this pull request
Apr 29, 2026
- Rename "(Secondary)" indicator to "(Read-only)" — read-only intent requests routing to a secondary but doesn't guarantee it (the listener may still route to the primary if no readable replica is available). - Deduplicate SqlConnectionStringBuilder construction by adding a GetConnectionString(username, password, db) overload on ServerConnection and routing both the dialog test path and the runtime path through it. - XAML nits: drop redundant Margin and trailing whitespace on the new Read-only intent checkbox. No behavior change. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements #301
Which component(s) does this affect?
How was this tested?
The "Connect to Server" dialog:
When connected to a Secondary, visually mention that.
Checklist
dotnet build -c Debug)dotnet test)