Fix deprecated sklearn fetch_mldata import#116
Open
ThomasJButler wants to merge 1 commit into
Open
Conversation
- Replace fetch_mldata with fetch_openml for MNIST data loading - Update function call to use 'mnist_784' dataset with version=1 and as_frame=False - Resolves ImportError: cannot import name 'fetch_mldata' from 'sklearn.datasets' fetch_mldata was deprecated in sklearn 0.20 and removed in sklearn 1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
generative_adversarial_network.pyscript fails to run due to a deprecated import:Error:
ImportError: cannot import name 'fetch_mldata' from 'sklearn.datasets'
fetch_mldatawas deprecated in scikit-learn 0.20 and removed in scikit-learn 1.2.Solution
fetch_mldatawithfetch_openmlfor MNIST data loading'mnist_784'dataset withversion=1andas_frame=FalseparametersTesting
Changes
from sklearn.datasets import fetch_mldata→from sklearn.datasets import fetch_openmlmnist = fetch_mldata('MNIST original')→mnist = fetch_openml('mnist_784', version=1, as_frame=False)This fix ensures compatibility with modern scikit-learn versions while maintaining backward compatibility with the existing codebase.