feat: Improve security of NF-e access key random code#52
Draft
mileo wants to merge 1 commit into
Draft
Conversation
This commit improves the security of the "Código Numérico" (random code) generation for the NF-e access key. The previous implementation used a predictable algorithm, which could be exploited to reconstruct NF-e access keys. This change introduces the ability to use a user-provided secret key to generate the random code using HMAC-SHA256, making it much harder to guess. The `ChaveEdoc` class now accepts a `secret_key` parameter. If provided, it's used to generate a secure random code. If not, it falls back to the old method for backward compatibility. A new test case has been added to verify the new functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the security of the "Código Numérico" (random code) generation for the NF-e access key.
The previous implementation used a predictable algorithm, which could be exploited to reconstruct NF-e access keys.
This change introduces the ability to use a user-provided secret key to generate the random code using HMAC-SHA256, making it much harder to guess.
The
ChaveEdocclass now accepts asecret_keyparameter. If provided, it's used to generate a secure random code. If not, it falls back to the old method for backward compatibility.A new test case has been added to verify the new functionality.