fix(checks): suppress name-drift false positives for plugin-namespaced skill names

Extended checkNameDrift to also accept the canonical split structure for plugin-namespaced skill names (prefix:local): dir == prefix and file == local. Adds two new test cases. No behavior change for non-namespaced names.

Author: protosphinx

src/checks.ts

@@ -129,21 +129,29 @@ function checkDescriptionLength(v: ValidatedSkill): Diagnostic[] {
 function checkNameDrift(v: ValidatedSkill): Diagnostic[] {
   const fileBase = basename(v.file).replace(/\.md$/, "");
   const dirBase = basename(dirname(v.file));
-  const expected = v.name.toLowerCase();
-  if (
-    fileBase.toLowerCase() !== expected &&
-    dirBase.toLowerCase() !== expected
-  ) {
-    return [
-      {
-        severity: "warn",
-        rule: "name-drift",
-        message: `frontmatter name '${v.name}' does not match filename '${fileBase}' or directory '${dirBase}'`,
-        file: v.file,
-      },
-    ];
+  const nameLower = v.name.toLowerCase();
+  const fileLower = fileBase.toLowerCase();
+  const dirLower = dirBase.toLowerCase();
+
+  if (fileLower === nameLower || dirLower === nameLower) return [];
+
+  // For plugin-namespaced names ("prefix:local"), also accept the
+  // canonical split structure: dir == prefix, file == local.
+  const colon = nameLower.indexOf(":");
+  if (colon !== -1) {
+    const prefix = nameLower.slice(0, colon);
+    const local = nameLower.slice(colon + 1);
+    if (dirLower === prefix && fileLower === local) return [];
   }
-  return [];
+
+  return [
+    {
+      severity: "warn",
+      rule: "name-drift",
+      message: `frontmatter name '${v.name}' does not match filename '${fileBase}' or directory '${dirBase}'`,
+      file: v.file,
+    },
+  ];
 }
 
 function checkEmptyBody(v: ValidatedSkill): Diagnostic[] {

test/checks.test.ts

@@ -290,4 +290,22 @@ describe("runChecks", () => {
     const ds = runChecks([s], config);
     expect(ds.find((d) => d.rule === "name-drift")).toBeUndefined();
   });
+
+  it("does not flag name-drift for a plugin-namespaced skill in canonical split structure", () => {
+    const s = mkSkill("/test/github/search.md", {
+      name: "github:search",
+      description: "search github repositories for code and issues",
+    });
+    const ds = runChecks([s], config);
+    expect(ds.find((d) => d.rule === "name-drift")).toBeUndefined();
+  });
+
+  it("flags name-drift for a plugin-namespaced skill when dir and file do not match either part", () => {
+    const s = mkSkill("/test/skills/something-else.md", {
+      name: "github:search",
+      description: "search github repositories for code and issues",
+    });
+    const ds = runChecks([s], config);
+    expect(ds.some((d) => d.rule === "name-drift")).toBe(true);
+  });
 });