prefer working with classlists

Erwin Dondorp · Erwin Dondorp · commit 7b172fe58ef2 · 2026-04-24T22:42:33.000+02:00
diff --git a/saltgui/static/sorttable/sorttable.js b/saltgui/static/sorttable/sorttable.js
@@ -60,7 +60,7 @@ export class SortTable {
     const theadrow = clickElement.parentNode;
     for(const cell of theadrow.childNodes) {
       if (cell.nodeType === 1) { // an element
-        if(cell.className.includes("sorttable_sorted")) prev_sorttable_columnindex = cell.sorttable_columnindex;
+        if(cell.classList.contains("sorttable_sorted")) prev_sorttable_columnindex = cell.sorttable_columnindex;
         cell.classList.remove("sorttable_sorted_reverse");
         cell.classList.remove("sorttable_sorted");
       }

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ export class SortTable {`
`60`	`60`	`const theadrow = clickElement.parentNode;`
`61`	`61`	`for(const cell of theadrow.childNodes) {`
`62`	`62`	`if (cell.nodeType === 1) { // an element`
`63`		`- if(cell.className.includes("sorttable_sorted")) prev_sorttable_columnindex = cell.sorttable_columnindex;`
	`63`	`+ if(cell.classList.contains("sorttable_sorted")) prev_sorttable_columnindex = cell.sorttable_columnindex;`
`64`	`64`	`cell.classList.remove("sorttable_sorted_reverse");`
`65`	`65`	`cell.classList.remove("sorttable_sorted");`
`66`	`66`	`}`