handle the output of some really old minions

Author: Erwin Dondorp

saltgui/static/scripts/issues/State.js

@@ -103,8 +103,13 @@ export class StateIssues extends Issues {
           continue;
         }
         const tr = Issues.addIssue(pPanel, "state", key);
-        Issues.addIssueMsg(tr, "State '" + stateData.__sls__ + "/" + stateData.__id__ + "' on '" + minionId + "' failed");
-        Issues.addIssueCmd(tr, "Apply state", minionId, ["state.sls_id", stateData.__id__, "mods=", stateData.__sls__]);
+        if (stateData.__sls__) {
+          Issues.addIssueMsg(tr, "State '" + stateData.__sls__ + "/" + stateData.__id__ + "' on '" + minionId + "' failed");
+          Issues.addIssueCmd(tr, "Apply state", minionId, ["state.sls_id", stateData.__id__, "mods=", stateData.__sls__]);
+        } else {
+          // really old minions do not fill __sls__
+          Issues.addIssueMsg(tr, "State '" + stateData.__id__ + "' on '" + minionId + "' failed");
+        }
         Issues.addIssueNav(tr, "job", {"id": jobData.jid, "minionid": minionId});
       }
     }

saltgui/static/scripts/output/Output.js

@@ -357,21 +357,24 @@ export class Output {
   }
 
   static _getIsSuccess (pMinionResponse) {
-    if (Output._hasProperties(pMinionResponse, ["retcode", "return", "success"])) {
+    // really old minions do not return 'retcode'
+    if (Output._hasProperties(pMinionResponse, ["return", "success"])) {
       return pMinionResponse.success;
     }
     return true;
   }
 
   static _getRetCode (pMinionResponse) {
-    if (Output._hasProperties(pMinionResponse, ["retcode", "return", "success"])) {
+    // but really old minions do not return 'retcode'
+    if (Output._hasProperties(pMinionResponse, ["return", "success"])) {
       return pMinionResponse.retcode;
     }
     return 0;
   }
 
   static _getMinionResponse (pCommand, pMinionResponse) {
-    if (Output._hasProperties(pMinionResponse, ["retcode", "return", "success"])) {
+    // really old minions do not return 'retcode'
+    if (Output._hasProperties(pMinionResponse, ["return", "success"])) {
       return pMinionResponse.return;
     }
     if (pCommand.startsWith("runner.") && pMinionResponse && pMinionResponse["return"] !== undefined) {

saltgui/static/scripts/panels/BeaconsMinion.js

@@ -106,6 +106,12 @@ export class BeaconsMinionPanel extends Panel {
     }
 
     const beacons0 = pLocalBeaconsListData.return[0][pMinionId];
+    // because some really old minion do not support beacons
+    if (this.showErrorRowInstead(beacons0)) {
+      this.setPlayPauseButton("none");
+      this.updateFooter();
+      return;
+    }
 
     const beacons = BeaconsPanel.fixBeaconsMinion(beacons0);
 

saltgui/static/scripts/panels/Jobs.js

@@ -180,6 +180,9 @@ export class JobsPanel extends Panel {
     this._hideJobs.push("wheel.key.list_all");
     this._hideJobs.push("wheel.key.reject");
 
+    // this was automatically executed by really old minions
+    this._hideJobs.push("mine.update");
+
     let numberOfJobsShown = 0;
     let numberOfJobsEligible = 0;
     const numberOfJobsPresent = jobs.length;

saltgui/static/scripts/panels/SchedulesMinion.js

@@ -49,6 +49,11 @@ export class SchedulesMinionPanel extends Panel {
     }
 
     let schedules = pLocalScheduleList.return[0][pMinionId];
+    // because some really old minion do not fully support schedules
+    if (this.showErrorRowInstead(schedules)) {
+      return;
+    }
+
     schedules = SchedulesPanel.fixSchedulesMinion(schedules);
 
     this.schedulesEnabled = schedules.enabled;