upgrade to ES2016 and documented the new versioning policy

Author: Erwin Dondorp

docs/README.md

@@ -1,6 +1,6 @@
 # SaltGUI
 
-SaltGUI is an open source web interface for managing a SaltStack server and its minions. Built using vanilla ES6 and implemented as a wrapper around the rest_cherrypy server a.k.a. salt-api.
+SaltGUI is an open source web interface for managing a SaltStack server and its minions. Built using plain ES2016 and implemented as a wrapper around the rest_cherrypy server a.k.a. salt-api.
 
 **Security Note**: For production deployments, TLS encryption is strongly recommended. See [TLS Configuration](#tls-configuration) for complete setup instructions.
 
@@ -16,6 +16,11 @@ IMPORTANT: The SaltGUI team can only support SaltStack versions 3006 and higher.
 That makes it very hard to perform proper testing for SaltGUI releases.
 We suggest to upgrade the SaltStack installation when you are still using a version that is older than that.
 
+IMPORTANT: Since the start of SaltGUI in 2016 and until early 2026, the SaltGUI team used ES6/ES2015 only.
+As time passes, that has now become an old version. We now upgrade SaltGUI to use the ES version that was current 5 years ago.
+That means we do not force that the latest browser is used.
+But note that browsers that are older than that are not detected and failures may then occur.
+
 [![CodeQL](https://github.com/erwindon/SaltGUI/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/erwindon/SaltGUI/actions/workflows/codeql-analysis.yml)
 
 ## Screenshots
@@ -696,7 +701,7 @@ So the simple advice is to upgrade when this occurs.
 
 
 ## Contributing
-Open a PR! Try to use no dependencies where possible, as vanilla JS is the aim. Any libraries will need to be heavily considered first. Please see the section above as PRs won't be reviewed if they don't pass the tests.
+Open a PR! Try to use no dependencies where possible, as plain JS is the aim. Any libraries will need to be heavily considered first. Please see the section above as PRs won't be reviewed if they don't pass the tests.
 
 
 ## Credits

saltgui/static/scripts/CommandBox.js

@@ -381,12 +381,10 @@ export class CommandBox {
       for (const panel of Router.currentPage.panels) {
         if (readOnlyScreens.includes(panel.key)) {
           // nothing changed on this screen
-        } else if (screenModifyingCommands[command].indexOf(panel.key) >= 0) {
-          // Arrays.includes() is only available from ES7/2016
+        } else if (screenModifyingCommands[command].includes(panel.key)) {
           // the command may have changed a specific panel
           panel.needsRefresh = true;
-        } else if (screenModifyingCommands[command].indexOf("*") >= 0) {
-          // Arrays.includes() is only available from ES7/2016
+        } else if (screenModifyingCommands[command].includes("*")) {
           // the command may have changed any panel
           panel.needsRefresh = true;
         }

saltgui/static/scripts/Router.js

@@ -142,8 +142,7 @@ export class Router {
       document.getElementById("button-" + pButtonId + nr).
         addEventListener("click", (pClickEvent) => {
           const pages = Router._getPagesList();
-          // Arrays.includes() is only available from ES7/2016
-          if (pUrl && (pButtonId === "logout" || pages.length === 0 || pages.indexOf(pButtonId) >= 0)) {
+          if (pUrl && (pButtonId === "logout" || pages.length === 0 || pages.includes(pButtonId))) {
             this.goTo(pUrl);
           }
           // hide the menu, it will stay hidden when the mouse is not over it
@@ -244,8 +243,7 @@ export class Router {
     let visible = true;
 
     // do not show unwanted menu items
-    // Arrays.includes() is only available from ES7/2016
-    if (pPages.length && pPages.indexOf(pPage.path) < 0) {
+    if (pPages.length && !pPages.includes(pPage.path)) {
       visible = false;
     }
 
@@ -262,8 +260,7 @@ export class Router {
     // still show a menu item when a child is visible
     let hasVisibleChild = false;
     for (const page of pChildren) {
-      // Arrays.includes() is only available from ES7/2016
-      if (pPages.indexOf(page) >= 0) {
+      if (pPages.includes(page)) {
         hasVisibleChild = true;
         break;
       }

saltgui/static/scripts/pages/Page.js

@@ -78,8 +78,7 @@ export class Page {
 
     const pages = Router._getPagesList();
     const page = Utils.getStorageItem("session", "menu_" + keyUpEvent.key, "");
-    // Arrays.includes() is only available from ES7/2016
-    if (page && (pages.length === 0 || pages.indexOf(page) >= 0)) {
+    if (page && (pages.length === 0 || pages.includes(page))) {
       this.router.goTo(page);
       return true;
     }

saltgui/static/scripts/panels/Keys.js

@@ -241,9 +241,7 @@ export class KeysPanel extends Panel {
     if (!Object.keys(pMinionsDict).length) {
       // list of well-known minion is empty
       // assume we actually don't known
-
-      // Arrays.includes() is only available from ES7/2016
-    } else if (!pIsMissing && Object.keys(pMinionsDict).indexOf(pMinionId) >= 0) {
+    } else if (!pIsMissing && Object.keys(pMinionsDict).includes(pMinionId)) {
       // this is a known minion
     } else {
       // this is an unknown minion

saltgui/static/scripts/panels/Options.js

@@ -377,8 +377,7 @@ export class OptionsPanel extends Panel {
           }
           const id = "option-" + name + "-value-" + valueArr[0] + "-" + label;
           const thisElement = document.getElementById(id);
-          // Arrays.includes() is only available from ES7/2016
-          if (value && varr.indexOf(label) >= 0) {
+          if (value && varr.includes(label)) {
             thisElement.checked = true;
           }
         }