implement all of all/none/reverse

Author: Erwin Dondorp

docs/README.md

@@ -402,11 +402,12 @@ But note that there might be more possible solutions, some of which may actually
 * A navigation-command to go to a page for more details.
 
 ## Minion selection
-Pages that show a simple list of minions allow individual miniuns to be selected.
+Pages that show a simple list of minions allow individual minions to be selected.
 Use panel button [✔] to show an extra column with checkboxes in the table.
-Minions can be selected one-by-one or the selection can be inverted by clicking on the column header.
+Minions can be selected one-by-one or you can use select-all, select-none by clicking on the column header.
+The selection can be inverted by using CTRL-click.
 The list of selected minions will be used in the command-box and for commands from a panel-menu.
-When the column is hidden, the selection-values are ignored.
+When the column is hidden, the selection-values are just ignored.
 
 ## Command documentation
 

saltgui/static/scripts/panels/Beacons.js

@@ -1,6 +1,5 @@
 /* global */
 
-import {Character} from "../Character.js";
 import {Panel} from "./Panel.js";
 import {Utils} from "../Utils.js";
 
@@ -23,7 +22,7 @@ export class BeaconsPanel extends Panel {
     const localBeaconsListPromise = this.api.getLocalBeaconsList(null);
 
     const selectVisible = Utils.getStorageItemBoolean("session", "select_visible", false);
-    this.showColumn(Character.HEAVY_CHECK_MARK, selectVisible);
+    this.showSelectColumn(selectVisible);
 
     this.nrMinions = 0;
 

saltgui/static/scripts/panels/Grains.js

@@ -1,6 +1,5 @@
 /* global jsonPath */
 
-import {Character} from "../Character.js";
 import {Output} from "../output/Output.js";
 import {Panel} from "./Panel.js";
 import {Utils} from "../Utils.js";
@@ -29,7 +28,7 @@ export class GrainsPanel extends Panel {
 
   onShow () {
     const selectVisible = Utils.getStorageItemBoolean("session", "select_visible", false);
-    this.showColumn(Character.HEAVY_CHECK_MARK, selectVisible);
+    this.showSelectColumn(selectVisible);
 
     if (this.previewColumsAdded !== true) {
       // collect the list of displayed extra grains

saltgui/static/scripts/panels/HighState.js

@@ -50,7 +50,7 @@ export class HighStatePanel extends Panel {
     const wheelKeyListAllPromise = this.api.getWheelKeyListAll();
 
     const selectVisible = Utils.getStorageItemBoolean("session", "select_visible", false);
-    this.showColumn(Character.HEAVY_CHECK_MARK, selectVisible);
+    this.showSelectColumn(selectVisible);
 
     this.nrMinions = 0;
 

saltgui/static/scripts/panels/Minions.js

@@ -44,7 +44,7 @@ export class MinionsPanel extends Panel {
     const runnerManageVersionsPromise = this.api.getRunnerManageVersions();
 
     const selectVisible = Utils.getStorageItemBoolean("session", "select_visible", false);
-    this.showColumn(Character.HEAVY_CHECK_MARK, selectVisible);
+    this.showSelectColumn(selectVisible);
 
     this.loadMinionsTxt();
 

saltgui/static/scripts/panels/Panel.js

@@ -79,7 +79,7 @@ export class Panel {
     span.addEventListener("click", (pClickEvent) => {
       const selectVisible = !Utils.getStorageItemBoolean("session", "select_visible", false);
       Utils.setStorageItem("session", "select_visible", selectVisible);
-      this.showColumn (Character.HEAVY_CHECK_MARK, selectVisible);
+      this.showSelectColumn(selectVisible);
       const tbody = this.table.tBodies[0];
       const selectMinions = Utils.getStorageItem("session", "select_minions", "");
       for (const tr of tbody.rows) {
@@ -221,6 +221,33 @@ export class Panel {
     this.updateFooter();
   }
 
+  selectAllNone () {
+    const lst = CommandBox.getSelectedMinionList();
+
+    let selectAll;
+    if (lst === null) {
+      selectAll = true;
+    } else {
+      const nrSelected = lst.split(",").length;
+      selectAll = nrSelected !== this.nrMinions;
+    }
+
+    let selectMinions = ",";
+    for (const tr of this.table.tBodies[0].children) {
+      const td = tr.children[0];
+      if (selectAll) {
+        td.innerText = Character.BALLOT_BOX_WITH_CHECK;
+        selectMinions += tr.dataset.minionId + ",";
+      } else {
+        td.innerText = Character.BALLOT_BOX_UNCHECKED;
+      }
+    }
+
+    Utils.setStorageItem("session", "select_minions", selectMinions);
+
+    this.updateFooter();
+  }
+
   addTable (pColumnNames, pFieldList = null) {
     const table = Utils.createElem("table", this.key, "", this.key + "-table");
 
@@ -242,8 +269,13 @@ export class Panel {
         if (!selectVisible) {
           th.style.display = "none";
         }
+        Utils.addToolTip(th, "Click here to select all/none\nCTRL-click to invert selection", "bottom-left");
         th.addEventListener("click", (pClickEvent) => {
-          this.toggleSelection();
+          if (pClickEvent.ctrlKey || pClickEvent.altKey) {
+            this.toggleSelection();
+          } else {
+            this.selectAllNone();
+          }
           pClickEvent.stopPropagation();
         });
       } else if (!columnName.startsWith("-")) {
@@ -1072,17 +1104,9 @@ export class Panel {
     }
   }
 
-  showColumn (pColTitle, pShow) {
+  showSelectColumn (pShow) {
 
-    let colNr = -1;
-    // find a column with this name
-    for (let i = 0; i < this.table.tHead.children[0].children.length; i++) {
-      const th = this.table.tHead.children[0].children[i];
-      if (th.innerText === pColTitle) {
-        colNr = i;
-        break;
-      }
-    }
+    const colNr = 0;
 
     // title
     for (const tr of this.table.tHead.children) {

saltgui/static/scripts/panels/Pillars.js

@@ -1,6 +1,5 @@
 /* global */
 
-import {Character} from "../Character.js";
 import {Panel} from "./Panel.js";
 import {Utils} from "../Utils.js";
 
@@ -27,7 +26,7 @@ export class PillarsPanel extends Panel {
     const localPillarObfuscatePromise = useCachePillar ? this.api.getRunnerCachePillar(null) : this.api.getLocalPillarObfuscate(null);
 
     const selectVisible = Utils.getStorageItemBoolean("session", "select_visible", false);
-    this.showColumn(Character.HEAVY_CHECK_MARK, selectVisible);
+    this.showSelectColumn(selectVisible);
 
     this.nrMinions = 0;
 

saltgui/static/scripts/panels/Schedules.js

@@ -1,6 +1,5 @@
 /* global */
 
-import {Character} from "../Character.js";
 import {Panel} from "./Panel.js";
 import {Utils} from "../Utils.js";
 
@@ -23,7 +22,7 @@ export class SchedulesPanel extends Panel {
     const localScheduleListPromise = this.api.getLocalScheduleList(null);
 
     const selectVisible = Utils.getStorageItemBoolean("session", "select_visible", false);
-    this.showColumn(Character.HEAVY_CHECK_MARK, selectVisible);
+    this.showSelectColumn(selectVisible);
 
     this.nrMinions = 0;