Skip to content

add proper syntax highlighting for returned data#624

Open
erwindon wants to merge 4 commits intomasterfrom
highlightjs
Open

add proper syntax highlighting for returned data#624
erwindon wants to merge 4 commits intomasterfrom
highlightjs

Conversation

@erwindon
Copy link
Copy Markdown
Owner

@erwindon erwindon commented Aug 11, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
SaltGui shows (structured) results in a plain way. A few low-level formatting tricks are use to format it.

Describe the solution you'd like
Use library that can do syntax highlighting on data.

Additional context

  • library must be free to use
  • library must be simple to use
  • library must be small (as shipped)

@erwindon erwindon self-assigned this Aug 11, 2024
@erwindon
Copy link
Copy Markdown
Owner Author

erwindon commented Aug 11, 2024 •
edited
Loading

use https://highlightjs.org/
download a bundle with only json and yaml (nested will use yaml)

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 11, 2024
View reviewed changes
@erwindon erwindon force-pushed the highlightjs branch 6 times, most recently from 7e26fb1 to 84fa546 Compare August 11, 2024 18:27
@erwindon erwindon mentioned this pull request Sep 13, 2024
Closed
@erwindon erwindon force-pushed the highlightjs branch 4 times, most recently from 9a05080 to 271ebac Compare October 25, 2024 18:51
Repository owner deleted a comment from sonarqubecloud bot Oct 25, 2024
@erwindon erwindon marked this pull request as ready for review October 25, 2024 19:01
@erwindon erwindon force-pushed the highlightjs branch 5 times, most recently from 6ef0104 to 914f76a Compare November 2, 2024 22:45
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 8, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
1 New issue
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 22, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@erwindon erwindon force-pushed the highlightjs branch 2 times, most recently from 071cdc7 to 991a407 Compare August 27, 2025 19:01
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@erwindon erwindon force-pushed the highlightjs branch 2 times, most recently from 2495ee8 to d714e9d Compare November 23, 2025 12:30
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 23, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
1 New issue
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 29, 2026

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@erwindon erwindon

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erwindon @github-advanced-security