Add: Initial implementation of polar_approx and unit tests#615
Open
mariam851 wants to merge 1 commit into
Open
Add: Initial implementation of polar_approx and unit tests#615mariam851 wants to merge 1 commit into
mariam851 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a new hypervolume approximation algorithm using Polar Coordinates (Deng & Zhang approach) as requested in issue #582. This method improves sampling efficiency in high-dimensional spaces.
Core Implementation: Added polar_approx class in src/utils/hv_algos/.
Ray Generation: Implemented generate_random_ray() using std::normal_distribution to ensure uniform sampling on the unit hypersphere surface.
Normalization: Added logic to ensure all generated rays are Unit Vectors and stay within the positive orthant.
CMake: Updated tests/CMakeLists.txt to register the new test case.
Unit Tests: Added a new test file to verify the mathematical properties of the generated rays (norm ≈ 1.0 and values ≥ 0).