Skip to content

Commit 38c707b

Browse files
authored
MINOR: Fix column comment getting overriden in glue (open-metadata#23329)
1 parent 76c4e37 commit 38c707b

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

ingestion/src/metadata/ingestion/source/database/athena/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def get_columns(self, connection, table_name, schema=None, **kw):
173173
for glue_col in glue_columns:
174174
col_name = glue_col["Name"]
175175
col_type = glue_col["Type"]
176-
col_comment = glue_col.get("Comment", "")
176+
col_comment = glue_col.get("Comment")
177177
col_parameters = glue_col.get("Parameters", {})
178178

179179
# Check if this is a non-current Iceberg column

ingestion/src/metadata/ingestion/source/database/glue/metadata.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ def get_columns(self, column_data: StorageDetails) -> Optional[Iterable[Column]]
406406
for glue_col in glue_columns:
407407
col_name = glue_col["Name"]
408408
col_type = glue_col["Type"]
409-
col_comment = glue_col.get("Comment", "")
409+
col_comment = glue_col.get("Comment")
410410
col_parameters = glue_col.get("Parameters", {})
411411

412412
# Check if this is a non-current Iceberg column
@@ -427,7 +427,7 @@ def get_columns(self, column_data: StorageDetails) -> Optional[Iterable[Column]]
427427
for glue_col in partition_keys:
428428
col_name = glue_col["Name"]
429429
col_type = glue_col["Type"]
430-
col_comment = glue_col.get("Comment", "")
430+
col_comment = glue_col.get("Comment")
431431
col_parameters = glue_col.get("Parameters", {})
432432

433433
# Check if this is a non-current Iceberg column

0 commit comments

Comments
 (0)