feat: apply hooks on installation

Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>

Author: neilime

packages/core/src/__snapshots__/core.e2e.spec.ts.snap

@@ -22,10 +22,10 @@ Applying migration "core - 20260604100000-migrate-to-vitest"...
 Migration "core - 20260604100000-migrate-to-vitest" applied!
 Symlinking dev dependencies...
 - Symlinking @biomejs/biome
-- Symlinking @vitest/coverage-v8
 - Symlinking @commitlint/cli
 - Symlinking @commitlint/config-conventional
 - Symlinking @types/node
+- Symlinking @vitest/coverage-v8
 - Symlinking vitest
 Symlinking dev dependencies done!
 Resolving peer dependencies...
@@ -60,10 +60,10 @@ Applying migration "core - 20260604100000-migrate-to-vitest"...
 Migration "core - 20260604100000-migrate-to-vitest" applied!
 Symlinking dev dependencies...
 - Symlinking @biomejs/biome
-- Symlinking @vitest/coverage-v8
 - Symlinking @commitlint/cli
 - Symlinking @commitlint/config-conventional
 - Symlinking @types/node
+- Symlinking @vitest/coverage-v8
 - Symlinking vitest
 Symlinking dev dependencies done!
 Resolving peer dependencies...

packages/core/src/install/migrations/20201024173398-init.spec.ts

@@ -1,9 +1,10 @@
 import { PackageJson } from "../../services/PackageJson";
+import { PackageManagerService } from "../../services/PackageManagerService";
 import {
   createProjectForTestFile,
   deleteTestProject,
 } from "../../tests/test-project";
-import { up } from "./20201024173398-init";
+import { hooks, up } from "./20201024173398-init";
 
 // Set to false to avoid using the cache
 const useCache = true;
@@ -42,4 +43,32 @@ describe("Migration 20201024173398-init", () => {
       expect(packageJsonContent).toMatchSnapshot();
     });
   });
+
+  describe("hooks", () => {
+    it("should export the managed hooks with a package-manager-aware pre-push command", () => {
+      const detectPackageManagerSpy = vi
+        .spyOn(PackageManagerService, "detectPackageManager")
+        .mockReturnValue("yarn");
+
+      try {
+        expect(hooks[0]).toEqual({
+          name: "pre-commit",
+          command:
+            "npx --no-install lint-staged && npx --no-install pretty-quick --staged",
+        });
+        expect(hooks[1]).toEqual({
+          name: "commit-msg",
+          command: "npx --no-install commitlint --edit $1",
+        });
+        expect(typeof hooks[2]?.command).toBe("function");
+        expect(
+          (hooks[2]?.command as (absoluteProjectDir: string) => string)(
+            testProjectDir,
+          ),
+        ).toBe("yarn run lint && yarn run build && yarn run test");
+      } finally {
+        detectPackageManagerSpy.mockRestore();
+      }
+    });
+  });
 });

packages/core/src/install/migrations/20201024173398-init.ts

@@ -1,9 +1,32 @@
 import { PROJECT_NAME } from "../../constants";
-import { GitService } from "../../services/GitService";
+import type { ManagedGitHook } from "../../services/HooksService";
 import type { MigrationUpFunction } from "../../services/MigrationsService";
 import { PackageJson } from "../../services/PackageJson";
 import { PackageManagerService } from "../../services/PackageManagerService";
 
+function getPackageManagerCommand(absoluteProjectDir: string): string {
+  return PackageManagerService.detectPackageManager(absoluteProjectDir);
+}
+
+export const hooks: ManagedGitHook[] = [
+  {
+    name: "pre-commit",
+    command:
+      "npx --no-install lint-staged && npx --no-install pretty-quick --staged",
+  },
+  {
+    name: "commit-msg",
+    command: "npx --no-install commitlint --edit $1",
+  },
+  {
+    name: "pre-push",
+    command: (absoluteProjectDir: string) => {
+      const packageManager = getPackageManagerCommand(absoluteProjectDir);
+      return `${packageManager} run lint && ${packageManager} run build && ${packageManager} run test`;
+    },
+  },
+];
+
 export const up: MigrationUpFunction = async (
   absoluteProjectDir: string,
 ): Promise<void> => {
@@ -90,25 +113,4 @@ export const up: MigrationUpFunction = async (
     scripts,
     jest,
   });
-
-  // Install Git hooks (only if we are in a git repository)
-  const isGitRepository = await GitService.isGitRepository(absoluteProjectDir);
-
-  if (isGitRepository) {
-    const gitHooks = {
-      "pre-commit":
-        "npx --no-install lint-staged && npx --no-install pretty-quick --staged",
-      "commit-msg": "npx --no-install commitlint --edit $1",
-      "pre-push": `${packageManager} run lint && ${packageManager} run build && ${packageManager} run test`,
-    };
-
-    for (const gitHookName of Object.keys(gitHooks)) {
-      const gitHookCommand = gitHooks[gitHookName as keyof typeof gitHooks];
-      await GitService.addGitHook(
-        absoluteProjectDir,
-        gitHookName,
-        gitHookCommand,
-      );
-    }
-  }
 };

packages/core/src/install/migrations/20260311120000-migrate-to-biome.spec.ts

@@ -1,16 +1,8 @@
-import {
-  existsSync,
-  mkdirSync,
-  readFileSync,
-  rmSync,
-  unlinkSync,
-  writeFileSync,
-} from "node:fs";
+import { existsSync, mkdirSync, rmSync, unlinkSync } from "node:fs";
 import { join } from "node:path";
 
 import { CmdService } from "../../services/CmdService";
 import { FileService } from "../../services/FileService";
-import { GitService } from "../../services/GitService";
 import {
   PackageJson,
   type PackageJsonContent,
@@ -19,10 +11,8 @@ import {
   createProjectForTestFile,
   deleteTestProject,
 } from "../../tests/test-project";
-import { up } from "./20260311120000-migrate-to-biome";
+import { hooks, up } from "./20260311120000-migrate-to-biome";
 
-const OLD_PRE_COMMIT_COMMAND =
-  "npx --no-install lint-staged && npx --no-install pretty-quick --staged";
 const BIOME_SCHEMA_URL_PATTERN =
   /https:\/\/biomejs\.dev\/schemas\/[^"]+\/schema\.json/;
 
@@ -92,20 +82,6 @@ describe("Migration 20260311120000-migrate-to-biome", () => {
       `,
       );
 
-      const preCommitHookPath = join(
-        testProjectDir,
-        ".git",
-        "hooks",
-        "pre-commit",
-      );
-      writeFileSync(
-        preCommitHookPath,
-        GitService.GIT_HOOK_TEMPLATE.replace(
-          "%gitHookCommand%",
-          OLD_PRE_COMMIT_COMMAND,
-        ),
-      );
-
       await up(testProjectDir);
 
       expect(
@@ -121,7 +97,6 @@ describe("Migration 20260311120000-migrate-to-biome", () => {
       ).toMatchSnapshot();
 
       expect(existsSync(eslintConfigFilePath)).toBe(false);
-      expect(readFileSync(preCommitHookPath, "utf-8")).toMatchSnapshot();
     });
 
     it("should keep custom eslint config files", async () => {
@@ -484,4 +459,16 @@ export default tsDevToolsCore;
       );
     });
   });
+
+  describe("hooks", () => {
+    it("should export the managed pre-commit hook", () => {
+      expect(hooks).toEqual([
+        {
+          name: "pre-commit",
+          command:
+            "npx --no-install biome check --error-on-warnings --staged --write",
+        },
+      ]);
+    });
+  });
 });

packages/core/src/install/migrations/20260311120000-migrate-to-biome.ts

@@ -3,7 +3,7 @@ import { dirname, join, relative } from "node:path";
 
 import { CmdService } from "../../services/CmdService";
 import { FileService } from "../../services/FileService";
-import { GitService } from "../../services/GitService";
+import type { ManagedGitHook } from "../../services/HooksService";
 import type { MigrationUpFunction } from "../../services/MigrationsService";
 import { PackageJson } from "../../services/PackageJson";
 
@@ -12,11 +12,16 @@ const ESLINT_CONFIG_FILE_NAME = "eslint.config.mjs";
 const PRE_COMMIT_HOOK_NAME = "pre-commit";
 const BIOME_INIT_COMMAND = "npx @biomejs/biome init";
 
-const OLD_PRE_COMMIT_COMMAND =
-  "npx --no-install lint-staged && npx --no-install pretty-quick --staged";
 const NEW_PRE_COMMIT_COMMAND =
   "npx --no-install biome check --error-on-warnings --staged --write";
 
+export const hooks: ManagedGitHook[] = [
+  {
+    name: PRE_COMMIT_HOOK_NAME,
+    command: NEW_PRE_COMMIT_COMMAND,
+  },
+];
+
 const MANAGED_ESLINT_MARKERS = [
   "tsDevToolsCore",
   "tsDevToolsReact",
@@ -83,7 +88,6 @@ export const up: MigrationUpFunction = async (
   enableBiomeVcsIntegration(absoluteProjectDir);
   migrateCommonViteStarterFiles(absoluteProjectDir);
   deleteManagedEslintConfig(absoluteProjectDir, hasManagedEslintConfigFile);
-  updateManagedPreCommitHook(absoluteProjectDir);
 };
 
 async function runBiomeInit(absoluteProjectDir: string): Promise<void> {
@@ -149,7 +153,7 @@ function getBiomeVcsRoot(absoluteProjectDir: string): string | undefined {
     return undefined;
   }
 
-  return relative(absoluteProjectDir, vcsRootPath) || undefined;
+  return relative(absoluteProjectDir, vcsRootPath);
 }
 
 function getEnclosingVcsRootPath(
@@ -293,12 +297,3 @@ function deleteManagedEslintConfig(
 
   unlinkSync(eslintConfigFilePath);
 }
-
-function updateManagedPreCommitHook(absoluteProjectDir: string): void {
-  GitService.updateGitHook(
-    absoluteProjectDir,
-    PRE_COMMIT_HOOK_NAME,
-    OLD_PRE_COMMIT_COMMAND,
-    NEW_PRE_COMMIT_COMMAND,
-  );
-}

packages/core/src/install/migrations/__snapshots__/20260311120000-migrate-to-biome.spec.ts.snap

@@ -50,14 +50,6 @@ exports[`Migration 20260311120000-migrate-to-biome > Up > should migrate ts-dev-
 "
 `;
 
-exports[`Migration 20260311120000-migrate-to-biome > Up > should migrate ts-dev-tools eslint and prettier setup to biome 3`] = `
-"#!/bin/sh
-
-# Created by ts-dev-tools (https://escemi-tech.github.io/ts-dev-tools/)
-
-npx --no-install biome check --error-on-warnings --staged --write"
-`;
-
 exports[`Migration 20260311120000-migrate-to-biome > Up > should not overwrite an existing biome config 1`] = `
 "{
   "vcs": {