Skip to content

test: remove deprecated cli arg#1657

Merged
neilime merged 5 commits into
mainfrom
fix/deprecated-cli-arg
Nov 7, 2025
Merged

test: remove deprecated cli arg#1657
neilime merged 5 commits into
mainfrom
fix/deprecated-cli-arg

Conversation

@neilime

@neilime neilime commented Nov 7, 2025

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>

@neilime neilime left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot fix failing tests:

E2E - core › Monorepo project › Installs core package
@ts-dev-tools/core: expect(received).toBeFalsy()
@ts-dev-tools/core: Received: "node:events:486
@ts-dev-tools/core: throw er; // Unhandled 'error' event
@ts-dev-tools/core: ^·
@ts-dev-tools/core: Error: spawn npm list --depth=1 --json --no-progress --pattern="@commitlint/config-nx-scopes" --non-interactive ENOENT
@ts-dev-tools/core: at ChildProcess._handle.onexit (node:internal/child_process:286:19)
@ts-dev-tools/core: at onErrorNT (node:internal/child_process:484:16)
@ts-dev-tools/core: at process.processTicksAndRejections (node:internal/process/task_queues:90:21)
@ts-dev-tools/core: Emitted 'error' event on ChildProcess instance at:
@ts-dev-tools/core: at ChildProcess._handle.onexit (node:internal/child_process:292:12)
@ts-dev-tools/core: at onErrorNT (node:internal/child_process:484:16)
@ts-dev-tools/core: at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
@ts-dev-tools/core: errno: -2,
@ts-dev-tools/core: code: 'ENOENT',
@ts-dev-tools/core: syscall: 'spawn npm list --depth=1 --json --no-progress --pattern="@commitlint/config-nx-scopes" --non-interactive',
@ts-dev-tools/core: path: 'npm list --depth=1 --json --no-progress --pattern="@commitlint/config-nx-scopes" --non-interactive',
@ts-dev-tools/core: spawnargs: []
@ts-dev-tools/core: }·
@ts-dev-tools/core: Node.js v24.11.0

Copilot AI commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

@neilime I've opened a new pull request, #1658, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 3 commits November 7, 2025 12:19
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
@neilime
neilime force-pushed the fix/deprecated-cli-arg branch 3 times, most recently from f4fe4e2 to afbf24a Compare November 7, 2025 14:38
@codecov

codecov Bot commented Nov 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.03%. Comparing base (c08a37c) to head (17674a7).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/core/src/services/PackageManagerService.ts 85.36% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
+ Coverage   88.93%   89.03%   +0.10%     
==========================================
  Files          31       31              
  Lines         723      757      +34     
  Branches      119      136      +17     
==========================================
+ Hits          643      674      +31     
- Misses         80       83       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Signed-off-by: Emilien Escalle <neilime@users.noreply.github.com>
@neilime
neilime force-pushed the fix/deprecated-cli-arg branch from afbf24a to 17674a7 Compare November 7, 2025 14:49
@neilime
neilime merged commit f471340 into main Nov 7, 2025
10 of 11 checks passed
@neilime
neilime deleted the fix/deprecated-cli-arg branch November 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants