You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: 41-code-review.md
+21Lines changed: 21 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -567,6 +567,27 @@ This tells the author you are happy for them to merge the pull request.
567
567
{alt='Merging a pull request in GitHub' .image-with-shadow width="800px"}
568
568
2. Delete the merged branch to reduce the clutter in the repository.
569
569
570
+
::: callout
571
+
572
+
### Merge via command line
573
+
574
+
The `git merge` command provides a way to directly merge branches on your local. In general, when adding changes to the `main` branch, this is not a good practice since it bypasses the code review process. It is a common practice for an open-source project to set its `main` branch protected, meaning pushing directly to `main` branch will fail. Therefore, even you can merge to `main` locally, you will not be able to push the changes to the remote repository.
575
+
576
+
On the other hand, the `git merge` command can be very useful for keeping your feature branch up to date with the `main` branch. For example, if you are working on a branch `my-feature` and the `main` branch has received new commits (e.g. someone else has merged their pull request), you can do the following to include changes from `main` into your feature branch:
577
+
578
+
```bash
579
+
# First update your local main branch
580
+
$ git checkout main
581
+
$ git pull main
582
+
# Then switch back to your feature branch and merge the latest main into it
583
+
$ git checkout my-feature
584
+
$ git merge main
585
+
```
586
+
587
+
In this way, you can keep your feature branch up to date. You may need to resolve conflicts that arise during this process.
@@ -22,4 +22,33 @@ Flimflam requires the following Python packages:
425
-
The following optional packages are required to run Flimflam's unit tests:
426
-
427
-
- [pytest](https://docs.pytest.org/en/stable/) - Flimflam's unit tests are written using pytest
428
-
-- [pytest-cov](https://pypi.org/project/pytest-cov/) - Adds test coverage stats to unit testing
429
-
\ No newline at end of file
430
-
+- [pytest-cov](https://pypi.org/project/pytest-cov/) - Adds test coverage stats to unit testing
431
-
+
432
-
+## Installation
433
-
+- Clone the repo ``git clone repo``
434
-
+- Check everything runs by running ``python -m pytest`` in the root directory
435
-
+- Hurray
436
-
+
437
-
+## Contributing
438
-
+- Create an issue [here](https://github.com/Onoddil/python-intermediate-inflammation/issues)
439
-
+ - What works, what does not? You tell me
440
-
+- Randomly edit some code and see if it improves things, then submit a [pull request](https://github.com/Onoddil/python-intermediate-inflammation/pulls)
441
-
+- Just yell at me while I edit the code, pair programmer style!
442
-
+
443
-
+## Getting Help
444
-
+- Nice try
445
-
+
446
-
+## Credits
447
-
+- Directed by Michael Bay
448
-
+
449
-
+## Citation
450
-
+Please cite [J. F. W. Herschel, 1829, MmRAS, 3, 177](https://ui.adsabs.harvard.edu/abs/1829MmRAS...3..177H/abstract) if you used this work in your day-to-day life.
451
-
+Please cite [C. Herschel, 1787, RSPT, 77, 1](https://ui.adsabs.harvard.edu/abs/1787RSPT...77....1H/abstract) if you actually use this for scientific work.
452
-
+
453
-
+## License
454
-
+This source code is protected under international copyright law. All rights
455
-
+reserved and protected by the copyright holders.
456
-
+This file is confidential and only available to authorized individuals with the
457
-
+permission of the copyright holders. If you encounter this file and do not have
458
-
+permission, please contact the copyright holders and delete this file.
459
-
\ No newline at end of file
460
-
```
461
-
462
-
So now we have added a tag, we need this reflected in our Github repository.
463
-
You can push this tag to your remote by doing:
464
-
465
-
```bash
466
-
$ git push origin v1.0.0
467
-
```
468
-
469
-
::::::::::::::::::::::::::::::::::::::::: callout
470
-
471
-
## What is a Version Number Anyway?
472
-
473
-
Software version numbers are everywhere,
474
-
and there are many different ways to do it.
475
-
A popular one to consider is [**Semantic Versioning**](https://semver.org/),
476
-
where a given version number uses the format MAJOR.MINOR.PATCH.
477
-
You increment the:
478
-
479
-
- MAJOR version when you make incompatible API changes
480
-
- MINOR version when you add functionality in a backwards compatible manner
481
-
- PATCH version when you make backwards compatible bug fixes
482
-
483
-
You can also add a hyphen followed by characters to denote a pre-release version,
484
-
e.g. 1.0.0-alpha1 (first alpha release) or 1.2.3-beta4 (fourth beta release)
@@ -22,4 +22,33 @@ Flimflam requires the following Python packages:
76
+
The following optional packages are required to run Flimflam's unit tests:
77
+
78
+
- [pytest](https://docs.pytest.org/en/stable/) - Flimflam's unit tests are written using pytest
79
+
-- [pytest-cov](https://pypi.org/project/pytest-cov/) - Adds test coverage stats to unit testing
80
+
\ No newline at end of file
81
+
+- [pytest-cov](https://pypi.org/project/pytest-cov/) - Adds test coverage stats to unit testing
82
+
+
83
+
+## Installation
84
+
+- Clone the repo ``git clone repo``
85
+
+- Check everything runs by running ``python -m pytest`` in the root directory
86
+
+- Hurray
87
+
+
88
+
+## Contributing
89
+
+- Create an issue [here](https://github.com/Onoddil/python-intermediate-inflammation/issues)
90
+
+ - What works, what does not? You tell me
91
+
+- Randomly edit some code and see if it improves things, then submit a [pull request](https://github.com/Onoddil/python-intermediate-inflammation/pulls)
92
+
+- Just yell at me while I edit the code, pair programmer style!
93
+
+
94
+
+## Getting Help
95
+
+- Nice try
96
+
+
97
+
+## Credits
98
+
+- Directed by Michael Bay
99
+
+
100
+
+## Citation
101
+
+Please cite [J. F. W. Herschel, 1829, MmRAS, 3, 177](https://ui.adsabs.harvard.edu/abs/1829MmRAS...3..177H/abstract) if you used this work in your day-to-day life.
102
+
+Please cite [C. Herschel, 1787, RSPT, 77, 1](https://ui.adsabs.harvard.edu/abs/1787RSPT...77....1H/abstract) if you actually use this for scientific work.
103
+
+
104
+
+## License
105
+
+This source code is protected under international copyright law. All rights
106
+
+reserved and protected by the copyright holders.
107
+
+This file is confidential and only available to authorized individuals with the
108
+
+permission of the copyright holders. If you encounter this file and do not have
109
+
+permission, please contact the copyright holders and delete this file.
110
+
\ No newline at end of file
111
+
```
112
+
113
+
So now we have added a tag, we need this reflected in our Github repository.
114
+
You can push this tag to your remote by doing:
115
+
116
+
```bash
117
+
$ git push origin v1.0.0
118
+
```
119
+
120
+
::::::::::::::::::::::::::::::::::::::::: callout
121
+
122
+
## What is a Version Number Anyway?
123
+
124
+
Software version numbers are everywhere,
125
+
and there are many different ways to do it.
126
+
A popular one to consider is [**Semantic Versioning**](https://semver.org/),
127
+
where a given version number uses the format MAJOR.MINOR.PATCH.
128
+
You increment the:
129
+
130
+
- MAJOR version when you make incompatible API changes
131
+
- MINOR version when you add functionality in a backwards compatible manner
132
+
- PATCH version when you make backwards compatible bug fixes
133
+
134
+
You can also add a hyphen followed by characters to denote a pre-release version,
135
+
e.g. 1.0.0-alpha1 (first alpha release) or 1.2.3-beta4 (fourth beta release)
0 commit comments