Skip to content

Use Ruff as linter#3

Merged
fnattino merged 11 commits into
mainfrom
ruff-fn
Oct 24, 2025
Merged

Use Ruff as linter#3
fnattino merged 11 commits into
mainfrom
ruff-fn

Conversation

@fnattino

Copy link
Copy Markdown

Drop pylint in favour of Ruff.

This could cover part of carpentries-incubator#491

@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/python-intermediate-development/compare/md-outputs..md-outputs-PR-3

The following changes were observed in the rendered markdown documents:

 16-verifying-code-style-linters.md           | 164 +++++++++++++++++----------
 17-section1-optional-exercises.md            |  29 +++--
 24-diagnosing-issues-improving-robustness.md | 113 +++++++++---------
 43-software-release.md                       |   4 +-
 md5sum.txt                                   |   8 +-
 5 files changed, 184 insertions(+), 134 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-10-23 19:52:24 +0000

github-actions Bot pushed a commit that referenced this pull request Oct 21, 2025
Comment thread episodes/16-verifying-code-style-linters.md Outdated
Comment thread episodes/16-verifying-code-style-linters.md Outdated
Comment thread episodes/16-verifying-code-style-linters.md Outdated
Comment thread episodes/24-diagnosing-issues-improving-robustness.md Outdated
Comment thread episodes/24-diagnosing-issues-improving-robustness.md Outdated
fnattino and others added 3 commits October 23, 2025 21:39
Co-authored-by: Sander van Rijn <svr003@gmail.com>
Co-authored-by: Sander van Rijn <svr003@gmail.com>
Co-authored-by: Sander van Rijn <svr003@gmail.com>
github-actions Bot pushed a commit that referenced this pull request Oct 23, 2025
github-actions Bot pushed a commit that referenced this pull request Oct 23, 2025
github-actions Bot pushed a commit that referenced this pull request Oct 23, 2025
github-actions Bot pushed a commit that referenced this pull request Oct 23, 2025
@fnattino

Copy link
Copy Markdown
Author

Thanks for the nice feedback @sjvrijn , I have included your suggestions! Do you have any other comments, or do you think this could be merged?

@sjvrijn sjvrijn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjusting, LGTM!

sjvrijn

This comment was marked as duplicate.

@fnattino fnattino merged commit 4848931 into main Oct 24, 2025
3 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 24, 2025
Auto-generated via `{sandpaper}`
Source  : 4848931
Branch  : main
Author  : Francesco Nattino <49899980+fnattino@users.noreply.github.com>
Time    : 2025-10-24 12:40:11 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/ruff-fn

Use Ruff as linter
github-actions Bot pushed a commit that referenced this pull request Oct 24, 2025
Auto-generated via `{sandpaper}`
Source  : 8eb382b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-10-24 12:41:06 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 4848931
Branch  : main
Author  : Francesco Nattino <49899980+fnattino@users.noreply.github.com>
Time    : 2025-10-24 12:40:11 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/ruff-fn

Use Ruff as linter
@sjvrijn sjvrijn deleted the ruff-fn branch October 25, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants