Fix desktop visible error states / 修复桌面可见错误状态#5119
Conversation
a175859 to
87f7a4a
Compare
87f7a4a to
1466e44
Compare
SivanCola
left a comment
There was a problem hiding this comment.
Thanks, I reviewed this against the latest main-v2 and the implementation looks directionally right: the Settings panel now exits the endless loading state on startup read failure, Workspace Changes keeps rendering session files while surfacing git-status failures, and pasted/dropped non-image attachment failures now use the existing toast path without exposing exception text.
I cannot approve it in the current state because the PR head is now conflicting with main-v2. Please rebase onto the latest main-v2 and resolve these conflicts before merge:
desktop/frontend/package.jsondesktop/frontend/src/__tests__/composer-goal-toggle.test.tsxdesktop/frontend/src/components/WorkspacePanel.tsx
When resolving WorkspacePanel.tsx, please preserve the newer code-preview/body class handling from main-v2 and then reapply the WorkspaceChangesView state shape plus git-unavailable warning. When resolving composer-goal-toggle.test.tsx, please keep the newer composer draft/session coverage from main-v2 and add this PR's attachment-failure assertions on top.
Related PR scan: this overlaps with Workspace Changes work in #4843, #4987, and #5245. I think this PR can still merge independently after rebase because it is narrowly about visible error states, but the final rebase should re-check the combined Workspace Changes UI.
Security/cache review: pass. I did not see new dependencies, network calls, command execution, privilege expansion, provider-visible prompt changes, tool-schema changes, provider request serialization changes, compaction changes, or reasoning upload changes.
Verified on the PR head:
git diff --check origin/main-v2...HEADpassedcorepack pnpm --dir desktop/frontend exec tsx src/__tests__/workspace-changes-errors.test.tsxpassedcorepack pnpm --dir desktop/frontend exec tsx src/__tests__/settings-refresh-snapshot.test.tsxpassedcorepack pnpm --dir desktop/frontend exec tsx src/__tests__/composer-goal-toggle.test.tsxpassed- GitHub checks are currently green on the old head, including
desktop, platform tests, CodeQL, andcache-impact
Once the conflicts are resolved and CI stays green on the rebased head, I will consider merging it into main-v2.
|
Pushed What changed:
Verified after the merge:
Note: GitHub now reports the PR as mergeable; required checks are still running on the new head. |
Summary
Verification
git diff --check(cd desktop/frontend && corepack pnpm test)(cd desktop/frontend && corepack pnpm build)(cd desktop && go test ./...)go test ./...Cache impact
Cache-impact: none - desktop frontend visible error/empty-state handling only; no provider-visible prompt, tool schema, request serialization, memory prefix, or cache-sensitive behavior changed.
Cache-guard:
(cd desktop/frontend && corepack pnpm test)covers the new Settings, Workspace Changes, and Composer regressions.System-prompt-review: N/A