Skip to content

fix(desktop): stop idle goal runs#5210

Closed
cyq1017 wants to merge 2 commits into
esengine:main-v2from
cyq1017:codex/reasonix-5200-stop-todos
Closed

fix(desktop): stop idle goal runs#5210
cyq1017 wants to merge 2 commits into
esengine:main-v2from
cyq1017:codex/reasonix-5200-stop-todos

Conversation

@cyq1017

@cyq1017 cyq1017 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • stop an idle active goal when Cancel has no foreground turn cancel function
  • clear the active goal from the desktop Stop button while goal mode is active
  • add backend and Composer regressions for stopping a goal/todo run

Fixes #5200.

Tests

  • go test ./internal/control -run 'TestCancelStopsIdleGoalWithIncompleteTodos|TestCancelClearsPendingApprovalRuntimeStatus|TestCancelClearsPendingAskRuntimeStatus|TestGoalCommandAutoContinuesUntilComplete|TestGoalModeSkipsAutoPlanApproval|TestGoalInterceptsCompleteWithIncompleteTodos' -count=1\n- npx pnpm@10 exec tsx src/tests/composer-goal-toggle.test.tsx\n- go test . -count=1 (desktop)\n- npx pnpm@10 run test:all (desktop/frontend)\n- go test ./... -count=1\n- git diff --check HEAD~1..HEAD\n

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) agent Core agent loop (internal/agent, internal/control) labels Jun 24, 2026
@cyq1017 cyq1017 marked this pull request as ready for review June 24, 2026 05:51
@SivanCola

Copy link
Copy Markdown
Collaborator

Closing this as superseded by the merged integration PR #5512.

What was kept/adapted:

Attribution:

Verification:

@SivanCola SivanCola closed this Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: to-dos 停止不了

2 participants