Allow plan-mode read-only command prefixes / 支持计划模式只读命令前缀#5867
Merged
SivanCola merged 3 commits intoJul 3, 2026
Conversation
github-actions
Bot
added
agent
github-actions
Bot
added
desktop
…-only-commands # Conflicts: # internal/boot/boot.go # internal/control/controller.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh issue view ...can be trusted once, for the session, or persisted as[agent].plan_mode_read_only_commands.task, andrun_skillremain blocked while planning.Related to #4572 and follow-up to #5246.
Validation
go test -count=1 ./internal/planmode ./internal/agent ./internal/control ./internal/boot ./internal/configgo test -count=1 ./internal/agent -run TestPlanModeDoesNotMutateSystemOrToolspnpm --dir desktop/frontend install --frozen-lockfile --offlinepnpm --dir desktop/frontend typecheckgit diff --checkCACHE_IMPACT_PR_BODY_FILE=/tmp/<body> CACHE_IMPACT_CHANGED_FILES_FILE=/tmp/<files> scripts/check-cache-impact.shCache impact
Cache-impact: low - plan-mode policy/config behavior changes, but this does not change provider-visible tool schemas or the stable system prompt shape.
Cache-guard:
go test -count=1 ./internal/agent -run TestPlanModeDoesNotMutateSystemOrToolsSystem-prompt-review: self-reviewed; startup/config routing and docs changed, with no intended stable system prompt or provider-visible tool schema change.