feat: change ESQuery Selector placeholder text based on language#104
Merged
nzakas merged 2 commits intoMay 14, 2025
Merged
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amareshsm
reviewed
May 14, 2025
amareshsm
reviewed
May 14, 2025
amareshsm
added
the
accepted
Member
Author
|
Thanks for pointing this out. I've added a new commit cdccb99. |
amareshsm
approved these changes
May 14, 2025
Member
amareshsm
left a comment
amareshsm
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
Would like to get one more review on this.
nzakas
approved these changes
May 14, 2025
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
LGTM.
This does, however, mean we have one more thing that needs to be updated whenever we add a new language. In a separate PR, could you please update https://github.com/eslint/code-explorer/blob/main/docs/adding-languages.md to ensure it's up-to-date with all of the required steps?
nzakas
deleted the
feat-change-esquery-selector-placeholder-text-based-on-language
branch
Member
Author
|
@nzakas Sure! I'll create a separate PR for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Hello,
Currently, the ESQuery Selector's placeholder remains the same even when switching to a language other than JavaScript.
To improve this, I added support for updating the ESQuery Selector placeholder based on the selected language.
Now, the placeholders correctly reflect language-specific examples!
e.g. "ImportDeclaration > Literal"regardless of the languageRelated Issues
Is there anything you'd like reviewers to focus on?