refactor: update outdated ESLint and OpenJS links - #322
Merged
Conversation
lumirlumir
requested changes
Jul 19, 2026
lumirlumir
left a comment
Member
There was a problem hiding this comment.
Thanks for opening the PR. I left one comment.
Also, I’m marking the PR title as refactor, since it modifies src/plugins/commit-message/createMessage.js.
Co-authored-by: lumir <yonghyeon0324@gmail.com>
Member
|
I’m closing and reopening this PR to rerun the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This repository still contains a few links that point to old domains and old documentation paths. They all respond with HTTP 200, so they appear to work, but following the redirects to their final destination reveals a defunct domain or a restructured docs path. This PR updates them to the URLs that
eslint/eslintcurrently uses.I verified each link's final destination by opening it directly in a browser.
What changes did you make? (Give an overview)
All three files are the same kind of link update, so I grouped them into a single PR. Happy to split it up if you'd prefer.
1.
CONTRIBUTING.mdhttps://js.foundation/community/code-of-conduct→https://eslint.org/conduct(The old link redirects to the foundation homepage rather than the Code of Conduct document. The new link also redirects, but it lands on the actual document, and
eslint/eslintuses this same link.)https://cla.js.foundation/eslint/eslint→https://cla.openjsf.org/.../docs/developer-guide/contributing/pull-requests→.../docs/latest/contribute/pull-requests(The old link still resolves via redirect, but it uses the old domain and old docs path.)
2.
docs/commit-message-check.mddocs/latest/contribute/...(the#step-2-make-your-changesstill exists on the new page, so it was kept).3.
src/plugins/commit-message/createMessage.jsdocs/latest/contribute/.Related Issues
None
Is there anything you'd like reviewers to focus on?
index.test.js.snap(108 lines) is the regenerated output fromjest -u, reflecting the updated link increateMessage.js. I reviewed the generated diff and confirmed that nothing other than the link string changed.