Skip to content

refactor: update outdated ESLint and OpenJS links - #322

Merged
lumirlumir merged 2 commits into
eslint:mainfrom
electrohyun:chore/update-outdated-links
Jul 20, 2026
Merged

refactor: update outdated ESLint and OpenJS links#322
lumirlumir merged 2 commits into
eslint:mainfrom
electrohyun:chore/update-outdated-links

Conversation

@electrohyun

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This repository still contains a few links that point to old domains and old documentation paths. They all respond with HTTP 200, so they appear to work, but following the redirects to their final destination reveals a defunct domain or a restructured docs path. This PR updates them to the URLs that eslint/eslint currently uses.

I verified each link's final destination by opening it directly in a browser.

What changes did you make? (Give an overview)

All three files are the same kind of link update, so I grouped them into a single PR. Happy to split it up if you'd prefer.

1. CONTRIBUTING.md

  • Code of Conduct link: https://js.foundation/community/code-of-conducthttps://eslint.org/conduct
    (The old link redirects to the foundation homepage rather than the Code of Conduct document. The new link also redirects, but it lands on the actual document, and eslint/eslint uses this same link.)
  • Also updated the link text from "JS Foundation" to "OpenJS Foundation".
  • CLA link: https://cla.js.foundation/eslint/eslinthttps://cla.openjsf.org/
  • Pull Request Guidelines link: .../docs/developer-guide/contributing/pull-requests.../docs/latest/contribute/pull-requests
    (The old link still resolves via redirect, but it uses the old domain and old docs path.)

2. docs/commit-message-check.md

  • Updated two old docs-path links to docs/latest/contribute/... (the #step-2-make-your-changes still exists on the new page, so it was kept).

3. src/plugins/commit-message/createMessage.js

  • Updated the link inside the comment message the bot posts on PRs to docs/latest/contribute/.

Related Issues

None

Is there anything you'd like reviewers to focus on?

  • The change to index.test.js.snap (108 lines) is the regenerated output from jest -u, reflecting the updated link in createMessage.js. I reviewed the generated diff and confirmed that nothing other than the link string changed.

@eslintbot eslintbot added this to Triage Jul 19, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Jul 19, 2026
@lumirlumir lumirlumir changed the title chore: update outdated ESLint and OpenJS links refactor: update outdated ESLint and OpenJS links Jul 19, 2026

@lumirlumir lumirlumir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR. I left one comment.

Also, I’m marking the PR title as refactor, since it modifies src/plugins/commit-message/createMessage.js.

Comment thread CONTRIBUTING.md Outdated
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Jul 20, 2026
Co-authored-by: lumir <yonghyeon0324@gmail.com>
@electrohyun
electrohyun requested a review from lumirlumir July 20, 2026 00:43
@lumirlumir

Copy link
Copy Markdown
Member

I’m closing and reopening this PR to rerun the CI.

@lumirlumir lumirlumir closed this Jul 20, 2026
@github-project-automation github-project-automation Bot moved this from Triaging to Complete in Triage Jul 20, 2026
@lumirlumir lumirlumir reopened this Jul 20, 2026
@github-project-automation github-project-automation Bot moved this from Complete to Evaluating in Triage Jul 20, 2026
@lumirlumir lumirlumir moved this from Evaluating to Triaging in Triage Jul 20, 2026

@lumirlumir lumirlumir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lumirlumir
lumirlumir merged commit 69840cc into eslint:main Jul 20, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from Triaging to Complete in Triage Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants