Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Please be sure to read the contribution guidelines before making or requesting a

## Code of Conduct

This project adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct). We kindly request that you read over our code of conduct before contributing.
This project adheres to the [OpenJS Foundation Code of Conduct](https://eslint.org/conduct). We kindly request that you read over our code of conduct before contributing.

## Filing Issues

Expand All @@ -16,4 +16,4 @@ This project adheres to the [JS Foundation Code of Conduct](https://js.foundatio

## Contributing Code

Please sign our [Contributor License Agreement](https://cla.js.foundation/eslint/eslint) and read over the [Pull Request Guidelines](https://eslint.org/docs/developer-guide/contributing/pull-requests).
Please sign our [Contributor License Agreement](https://openjsf.org/cla) and read over the [Pull Request Guidelines](https://eslint.org/docs/latest/contribute/pull-requests).
4 changes: 2 additions & 2 deletions docs/commit-message-check.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

## Background

`eslint-github-bot`'s commit message check ensures that all pull requests which get merged into `main` have a valid commit message, based on [ESLint's commit message guidelines](https://eslint.org/docs/developer-guide/contributing/pull-requests#step-2-make-your-changes).
`eslint-github-bot`'s commit message check ensures that all pull requests which get merged into `main` have a valid commit message, based on [ESLint's commit message guidelines](https://eslint.org/docs/latest/contribute/pull-requests#step-2-make-your-changes).

The ESLint team uses GitHub's "Squash and Merge" feature to merge pull requests. When using this feature, the default commit message for the squashed commit is the title of the pull request. To minimize the risk of an incorrect commit message getting merged into `main`, `eslint-github-bot` checks the title.

## How do I fix it?

If this status check is failing on your pull request, you should fix your pull request title on github.com to conform to [ESLint's commit message guidelines](https://eslint.org/docs/developer-guide/contributing/pull-requests#step-2-make-your-changes).
If this status check is failing on your pull request, you should fix your pull request title on github.com to conform to [ESLint's commit message guidelines](https://eslint.org/docs/latest/contribute/pull-requests#step-2-make-your-changes).

![](./edit-pr-title-explanation.png)
2 changes: 1 addition & 1 deletion src/plugins/commit-message/createMessage.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ ${errorMessages.join("\n")}

**To Fix:** You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint [here](https://eslint.org/docs/developer-guide/contributing/)
Read more about contributing to ESLint [here](https://eslint.org/docs/latest/contribute/)
`;
};
Loading