fix: resolve all ESLint errors across test files

- e2e/settings.spec.ts: remove unused createLandscapePng/uploadTestImage imports
- App.test.tsx: replace `as any` with `as unknown as <T>` for matchMedia and FileReader mocks
- PhotoGrid.test.tsx: remove unused beforeEach import; replace `as any` with `as unknown as <T>` for anchor/ClipboardItem/fetch mocks
- heicUtils.test.ts: replace `as any` with `as unknown as HTMLCanvasElement` in createElement mocks
- useDarkMode.test.ts: replace `as any` with `as unknown as typeof window.matchMedia`
- imageUtils.test.ts: remove unused WatermarkPosition import; drop unused _quality param; fix no-this-alias by using arrow function in property setter; remove unused result variables

Agent-Logs-Url: https://github.com/esmcelroy/squarify/sessions/10d4fd08-d586-4419-a6d9-aeb5da278869

Co-authored-by: esmcelroy <3530006+esmcelroy@users.noreply.github.com>

Author: Copilot

e2e/settings.spec.ts

@@ -1,5 +1,4 @@
 import { test, expect } from '@playwright/test'
-import { createLandscapePng, uploadTestImage } from './test-helpers'
 
 test.beforeEach(async ({ page }) => {
   await page.goto('/')

src/__tests__/App.test.tsx

@@ -39,7 +39,7 @@ describe('App', () => {
       addListener: vi.fn(),
       removeListener: vi.fn(),
       dispatchEvent: vi.fn(),
-    })) as any;
+    })) as unknown as MediaQueryList;
   });
 
   afterEach(() => {
@@ -114,7 +114,7 @@ describe('App', () => {
         setTimeout(() => this.onload?.(), 0);
       }
     }
-    global.FileReader = MockFileReader as any;
+    global.FileReader = MockFileReader as unknown as typeof FileReader;
 
     return {
       restore: () => { global.FileReader = origFileReader; },

src/__tests__/PhotoGrid.test.tsx

@@ -1,4 +1,4 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, vi, afterEach } from 'vitest';
 import { render, screen, fireEvent, act } from '@testing-library/react';
 import { PhotoGrid } from '../components/PhotoGrid';
 import type { UploadedPhoto } from '../types';
@@ -70,7 +70,7 @@ describe('PhotoGrid', () => {
     const clickSpy = vi.fn()
     const createElementSpy = vi.spyOn(document, 'createElement').mockImplementation((tag: string) => {
       if (tag === 'a') {
-        return { href: '', download: '', click: clickSpy } as any
+        return { href: '', download: '', click: clickSpy } as unknown as HTMLAnchorElement
       }
       return originalCreateElement(tag)
     })
@@ -116,13 +116,13 @@ describe('PhotoGrid', () => {
     })
     globalThis.ClipboardItem = class {
       constructor(public items: Record<string, Blob>) {}
-    } as any
+    } as unknown as typeof ClipboardItem
 
     const pngBlob = new Blob(['px'], { type: 'image/png' })
     const mockFetch = vi.fn().mockResolvedValue({
       blob: () => Promise.resolve(pngBlob),
     })
-    window.fetch = mockFetch as any
+    window.fetch = mockFetch as unknown as typeof fetch
 
     const photos = [
       makePhoto({ id: 'p1', paddedDataUrl: 'data:image/png;base64,padded' }),
@@ -160,7 +160,7 @@ describe('PhotoGrid', () => {
           set(v: string) { downloadFilename = v },
           get() { return downloadFilename },
         })
-        return anchor as any
+        return anchor as unknown as HTMLAnchorElement
       }
       return originalCreateElement(tag)
     })
@@ -187,7 +187,7 @@ describe('PhotoGrid', () => {
           set(v: string) { downloadFilename = v },
           get() { return downloadFilename },
         })
-        return anchor as any
+        return anchor as unknown as HTMLAnchorElement
       }
       return originalCreateElement(tag)
     })

src/__tests__/heicUtils.test.ts

@@ -117,7 +117,7 @@ describe('convertHeicToJpeg', () => {
     }])
     const mockCanvas = makeMockCanvas()
     createElementSpy = vi.spyOn(document, 'createElement').mockImplementation((tag: string) => {
-      if (tag === 'canvas') return mockCanvas as any
+      if (tag === 'canvas') return mockCanvas as unknown as HTMLCanvasElement
       return originalCreateElement(tag)
     })
   })
@@ -150,7 +150,7 @@ describe('convertHeicToJpeg', () => {
     createElementSpy.mockRestore()
     const mockCanvas = makeMockCanvas(null)
     createElementSpy = vi.spyOn(document, 'createElement').mockImplementation((tag: string) => {
-      if (tag === 'canvas') return mockCanvas as any
+      if (tag === 'canvas') return mockCanvas as unknown as HTMLCanvasElement
       return originalCreateElement(tag)
     })
 
@@ -173,7 +173,7 @@ describe('processFilesForHeic', () => {
     }])
     const mockCanvas = makeMockCanvas()
     createElementSpy = vi.spyOn(document, 'createElement').mockImplementation((tag: string) => {
-      if (tag === 'canvas') return mockCanvas as any
+      if (tag === 'canvas') return mockCanvas as unknown as HTMLCanvasElement
       return originalCreateElement(tag)
     })
   })

src/__tests__/imageUtils.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
 import { findMaxAspectRatio, getImageDimensions, padImageToAspectRatio, drawPatternFill, drawWatermark, getWatermarkPosition } from '../lib/imageUtils'
-import type { UploadedPhoto, PaddingSettings, PatternSettings, WatermarkSettings, WatermarkPosition } from '../types'
+import type { UploadedPhoto, PaddingSettings, PatternSettings, WatermarkSettings } from '../types'
 
 function makePhoto(width: number, height: number, overrides?: Partial<UploadedPhoto>): UploadedPhoto {
   return {
@@ -92,7 +92,7 @@ function installCanvasMocks() {
 
   HTMLCanvasElement.prototype.getContext = vi.fn(() => mockCtx) as unknown as typeof HTMLCanvasElement.prototype.getContext
   HTMLCanvasElement.prototype.toDataURL = vi.fn(
-    (type?: string, _quality?: unknown) => `data:${type ?? 'image/png'};base64,MOCK`
+    (type?: string) => `data:${type ?? 'image/png'};base64,MOCK`
   )
 }
 
@@ -108,13 +108,12 @@ function installImageMock(naturalWidth = 800, naturalHeight = 600) {
     onerror: ((err: unknown) => void) | null = null
 
     constructor() {
-      const self = this
       // Auto-fire onload on next microtask after src is set
       Object.defineProperty(this, 'src', {
-        get: () => self._src,
-        set(value: string) {
-          self._src = value
-          queueMicrotask(() => self.onload?.())
+        get: () => this._src,
+        set: (value: string) => {
+          this._src = value
+          queueMicrotask(() => this.onload?.())
         },
       })
     }
@@ -288,15 +287,15 @@ describe('padImageToAspectRatio', () => {
   it('outputs webp format with quality', async () => {
     const photo = makePhoto(600, 600, { dataUrl: 'data:img' })
     const settings = defaultSettings({ outputFormat: 'webp', outputQuality: 0.9 })
-    const result = await padImageToAspectRatio(photo, 2, settings)
+    await padImageToAspectRatio(photo, 2, settings)
 
     expect(HTMLCanvasElement.prototype.toDataURL).toHaveBeenCalledWith('image/webp', 0.9)
   })
 
   it('outputs png format without quality parameter', async () => {
     const photo = makePhoto(600, 600, { dataUrl: 'data:img' })
     const settings = defaultSettings({ outputFormat: 'png' })
-    const result = await padImageToAspectRatio(photo, 2, settings)
+    await padImageToAspectRatio(photo, 2, settings)
 
     expect(HTMLCanvasElement.prototype.toDataURL).toHaveBeenCalledWith('image/png', undefined)
   })

src/__tests__/useDarkMode.test.ts

@@ -34,12 +34,12 @@ describe('useDarkMode', () => {
       mockListeners.push(...listeners);
       // Keep reference so listeners added later are captured
       const origAddEventListener = mql.addEventListener as ReturnType<typeof vi.fn>;
-      (mql as any).addEventListener = vi.fn((_event: string, handler: (e: { matches: boolean }) => void) => {
+      (mql as unknown as Record<string, unknown>).addEventListener = vi.fn((_event: string, handler: (e: { matches: boolean }) => void) => {
         mockListeners.push(handler);
         origAddEventListener(_event, handler);
       });
       return mql;
-    }) as any;
+    }) as unknown as typeof window.matchMedia;
   });
 
   afterEach(() => {
@@ -104,7 +104,7 @@ describe('useDarkMode', () => {
     window.matchMedia = vi.fn(() => {
       const { mql } = createMatchMedia(true);
       return mql;
-    }) as any;
+    }) as unknown as typeof window.matchMedia;
     const { result } = renderHook(() => useDarkMode());
     expect(result.current[0]).toBe('system');
     expect(result.current[2]).toBe(true);