fix: resolve blank sub-storybook pages on packets.es.net#92
Open
FreddKM wants to merge 11 commits into
Open
Conversation
Unified all three packages at 2.0.1-beta.0. Includes CSS variable prefix rename (--esnet- to --pkts-), component style migration into ui-css, new PktsChipGroup web component, Button/IconButton prop refactor, and multiple bug fixes.
Fix ui-css class prefix from es- to pkts-, add all missing components to ui-react and ui-css component lists, add pkts-chip-group to ui-web.
ui-react: add PktsSkeletonChip missing from list, add PacketsDesignTokenProvider and usePacketsDesignTokens, split PktsTab/PktsTabs correctly, reorganize into categories matching source ui-web: rewrite component list to match index.ts exports exactly, fix date picker sub-components, remove components that are not exported ui-css: fix all class names from es- to pkts- prefix, remove input-date (file does not exist), add all migrated components from this release
Tokens CSS is fully inlined by postcss-import at build time. Listing it as a runtime dependency caused install failures for consumers who don't have ESnet registry access.
Dockerfile: use build:storybook in react-docs instead of build, which was running the Cloudflare assembly script and clobbering the output directory with the wrong content for the Docker/nginx deployment. host-docs MDX: add target="_parent" to all internal ?path= links so clicks navigate the Storybook manager frame instead of the iframe, which only accepts /story/ paths and throws on /docs/ paths.
Deploying packets-design-system-staging with
|
| Latest commit: |
daa8edc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://03ed25e0.packets-design-system-staging.pages.dev |
| Branch Preview URL: | https://fix-packets-site-blank-story.packets-design-system-staging.pages.dev |
Deploying packets-design-system with
|
| Latest commit: |
daa8edc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d7fcccff.packets-design-system.pages.dev |
| Branch Preview URL: | https://fix-packets-site-blank-story.packets-design-system.pages.dev |
… example - All three READMEs: install commands now include @beta tag so external testers get 2.x instead of the old stable 0.x/1.x release - ui-react package.json: removed ./style.css export (no CSS file ships in the tarball) and ./src/* export (src/ is not in the published files list); both caused MODULE_NOT_FOUND for any consumer who imported them - ui-react README: fixed PktsAvatar usage example — initials and color are not props; correct props are alt (drives the fallback label) and backgroundColor
pnpm build (via Turborepo) was calling the Cloudflare assembly script instead of the standard Storybook build, crashing CI. Renamed the scripts so build runs storybook build everywhere consistently, and build:cloudflare is the Cloudflare-specific entry point. Dockerfile updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes four issues found during external beta testing, plus the blank sub-storybook pages on packets.es.net.
Site fixes (already cherry-picked to release/2.0.1-beta.1):
Dockerfile:react-docswas callingpnpm run buildwhich runs the Cloudflare assembly script instead of building the Storybook — changed tobuild:storybookhost-docsMDX: internal?path=/docs/...links were navigating inside the iframe, which only accepts/story/paths — addedtarget="_parent"to all of themPackage fixes (will ship as beta.2):
@betaso external testers get 2.x instead of the old stable releaseui-reactpackage.json: removed./style.cssand./src/*exports — neither path exists in the published tarball, causingMODULE_NOT_FOUNDfor any consumer who imported themui-reactREADME: fixedPktsAvatarusage example —initialsandcolorare not props; correct props arealtandbackgroundColor