Use terrain overlay mesh as material source#339
Conversation
esnya
force-pushed
the
codex/type-import-destination
branch
from
d99be29 to
bdbe594
Compare
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
0477b49 to
92df664
Compare
esnya
force-pushed
the
codex/type-import-destination
branch
from
bdbe594 to
88942d2
Compare
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
92df664 to
803ae6c
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 803ae6c64b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 983afead75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
983afea to
3a1688b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a1688b1e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
3a1688b to
269fe57
Compare
esnya
force-pushed
the
codex/type-import-destination
branch
from
88942d2 to
eb73c5f
Compare
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
269fe57 to
b95e285
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b95e285ef4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
b95e285 to
9a0597c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a0597cec0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
9a0597c to
802ab63
Compare
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
802ab63 to
373bc93
Compare
|
現時点では受け入れ不可です。#351 が main に merge された後の最新状態で、この PR は GitHub 上 mergeable=CONFLICTING / mergeStateStatus=DIRTY になっています。前回指摘した overlay license mode の identity 問題は最新 head で修正されていましたが、現在は main に対して機械的に merge できないため、競合解消後に再レビューが必要です。 |
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
373bc93 to
4db4d3f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4db4d3f32f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
TerrainOverlayMaterialBindingderive its material mesh code solely fromTerrainTextureOverlay.MeshCodeTerrainOverlayMaterialSourcePartitionerVerification
dotnet restore PlateauResoniteLink.sln --locked-mode --disable-build-serversdotnet format whitespace . --folder --verify-no-changesdotnet build PlateauResoniteLink.sln --configuration Release --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=falsedotnet test PlateauResoniteLink.sln --configuration Release --no-restore --verbosity normal -m:1 --disable-build-servers -p:UseSharedCompilation=falseplateau-13213-higashimurayama-shi-2020mesh53395325, compared withgit diff --no-indexagainst the semantic baseline: no diff