Split in-memory texture source variants#340
Open
esnya wants to merge 7 commits into
Open
Conversation
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
0477b49 to
92df664
Compare
esnya
force-pushed
the
codex/type-inmemory-texture-source
branch
3 times, most recently
from
ee5e500 to
a416061
Compare
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
983afea to
3a1688b
Compare
esnya
force-pushed
the
codex/type-inmemory-texture-source
branch
from
a416061 to
7911733
Compare
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
3a1688b to
269fe57
Compare
esnya
force-pushed
the
codex/type-inmemory-texture-source
branch
from
7911733 to
40ac3b0
Compare
esnya
force-pushed
the
codex/type-surface-material-source
branch
from
269fe57 to
b95e285
Compare
esnya
force-pushed
the
codex/type-inmemory-texture-source
branch
from
40ac3b0 to
42cb588
Compare
esnya
force-pushed
the
codex/type-inmemory-texture-source
branch
from
42cb588 to
2f854f7
Compare
This was referenced Jun 2, 2026
esnya
commented
Jun 3, 2026
esnya
force-pushed
the
codex/type-inmemory-texture-source
branch
from
2f854f7 to
f292458
Compare
Owner
Author
|
現時点では受け入れ不可です。#351 が main に merge された後の最新状態で、この PR は GitHub 上 mergeable=CONFLICTING / mergeStateStatus=DIRTY になっています。前回指摘した raw RGBA32 payload 長検証は最新 head で修正されていましたが、現在は main に対して機械的に merge できないため、競合解消後に再レビューが必要です。 |
esnya
force-pushed
the
codex/type-inmemory-texture-source
branch
from
f292458 to
5cd9424
Compare
esnya
commented
Jun 4, 2026
| int height, | ||
| string? colorProfile, | ||
| byte[] bytes) | ||
| : base(width, height, colorProfile, bytes) |
Owner
Author
There was a problem hiding this comment.
HDR payload も RGBA32 と同様に constructor で byte 長を検証してください。現状は RgbaFloat32RawTexturePayload が任意長の �yte[] を受け入れるため、width * height * 16 ではない不正な HDR texture payload が ImportRawHdrTextureAsync までそのまま流れます。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TexturePayloadFormatwhenTexturePayloadis constructedVerification
dotnet restore PlateauResoniteLink.sln --locked-mode --disable-build-serversdotnet format whitespace . --folder --verify-no-changesdotnet build PlateauResoniteLink.sln --configuration Release --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=falsedotnet test PlateauResoniteLink.sln --configuration Release --no-restore --verbosity normal -m:1 --disable-build-servers -p:UseSharedCompilation=falseplateau-13213-higashimurayama-shi-2020mesh53395325, compared withgit diff --no-indexagainst the semantic baseline: no diff