Skip to content

Type texture payload variants#353

Closed
esnya wants to merge 1 commit into
codex/type-inmemory-raw-texture-dimensionsfrom
codex/type-texture-payload-variants
Closed

Type texture payload variants#353
esnya wants to merge 1 commit into
codex/type-inmemory-raw-texture-dimensionsfrom
codex/type-texture-payload-variants

Conversation

@esnya
Copy link
Copy Markdown
Owner

@esnya esnya commented Jun 2, 2026

Summary

  • Split neutral TexturePayload into RawRgba32TexturePayload and EncodedImageTexturePayload.
  • Remove the contract-level TexturePayloadFormat discriminator and raw Width ?? throw / Height ?? throw path from SceneImportContractMapper.
  • Update upstream appearance loading and test helpers to choose the concrete texture payload variant at creation time.

Verification

  • dotnet restore PlateauResoniteLink.sln --locked-mode --disable-build-servers
  • dotnet format whitespace . --folder --verify-no-changes
  • dotnet build PlateauResoniteLink.sln --configuration Release --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=false
  • dotnet test PlateauResoniteLink.sln --configuration Release --no-restore --verbosity normal -m:1 --disable-build-servers -p:UseSharedCompilation=false (1021 passed)
  • Fake Live Sink canonical dump completed for plateau-13213-higashimurayama-shi-2020 mesh 53395325, packages dem,bldg, terrain mesh grid.
  • git diff --no-index against the semantic baseline was non-empty only in the already-stacked PresentationCommon dedicated-material output from the parent branch; no texture payload variant-specific dump regression was observed. Temporary dump was deleted.

Notes

  • This is intentionally not a same-shape wrapper: raw payloads are the only contract type with non-null Width, Height, and BinaryPayload; encoded image payloads carry source-backed image data with optional dimensions.
  • Target-internal ResoniteTexturePayloadFormat remains a separate follow-up candidate because it is downstream of the neutral import contract boundary.

@esnya esnya force-pushed the codex/type-resonite-material-asset-binding branch from 1e55037 to b2ca141 Compare June 2, 2026 17:03
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from 1ea3d1f to 0f8edcf Compare June 2, 2026 17:13
@esnya esnya force-pushed the codex/type-resonite-material-asset-binding branch from b2ca141 to c91f814 Compare June 2, 2026 18:24
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from 0f8edcf to c601f6e Compare June 2, 2026 18:24
@esnya esnya force-pushed the codex/type-resonite-material-asset-binding branch from c91f814 to fa0eb99 Compare June 2, 2026 19:16
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from c601f6e to 5410aa3 Compare June 2, 2026 19:16
@esnya esnya force-pushed the codex/type-resonite-material-asset-binding branch from fa0eb99 to 7e24e00 Compare June 2, 2026 19:34
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from 5410aa3 to 609699a Compare June 2, 2026 19:34
@esnya esnya force-pushed the codex/type-resonite-material-asset-binding branch from 7e24e00 to cce651b Compare June 2, 2026 19:59
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from 609699a to c34effc Compare June 2, 2026 19:59
@esnya esnya force-pushed the codex/type-resonite-material-asset-binding branch from cce651b to 4d321a8 Compare June 2, 2026 20:48
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from c34effc to a2d73c6 Compare June 2, 2026 20:48
@esnya esnya changed the base branch from codex/type-resonite-material-asset-binding to codex/type-inmemory-raw-texture-dimensions June 2, 2026 20:49
@esnya
Copy link
Copy Markdown
Owner Author

esnya commented Jun 2, 2026

Superseded by #340: these texture source/payload changes depend on the same upstream texture boundary and have been folded into the main-target #340 PR instead of keeping a dependent stack.

@esnya esnya closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant