Type Resonite texture payload variants#354
Closed
esnya wants to merge 1 commit into
Closed
Conversation
1ea3d1f to
0f8edcf
Compare
8db6f10 to
c1b43cc
Compare
0f8edcf to
c601f6e
Compare
c1b43cc to
1688d2c
Compare
c601f6e to
5410aa3
Compare
1688d2c to
4188c2c
Compare
5410aa3 to
609699a
Compare
4188c2c to
42a903f
Compare
609699a to
c34effc
Compare
42a903f to
7de5429
Compare
c34effc to
a2d73c6
Compare
7de5429 to
c9809de
Compare
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResoniteTexturePayloadintoRawRgba32ResoniteTexturePayloadandEncodedImageResoniteTexturePayloadso raw payload dimensions and bytes are available without nullable fallback.ResoniteTexturePayloadFormatand switched target/test adapters to concrete payload pattern matching.Notes
private protectedconstruction without record copy-constructor escape, and so existing reference-identity behavior stays unchanged.Width,Height, andBinaryPayload; encoded payloads carry an import source and optional metadata dimensions.Verification
dotnet restore PlateauResoniteLink.sln --locked-mode --disable-build-serversdotnet format whitespace . --folder --verify-no-changesdotnet build PlateauResoniteLink.sln --configuration Release --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=falsedotnet test PlateauResoniteLink.sln --configuration Release --no-restore --verbosity normal -m:1 --disable-build-servers -p:UseSharedCompilation=false(1021 passed)plateau-13213-higashimurayama-shi-2020/53395325/dem,bldg/gridcompleted.git diff --no-indexagainstruntime/windows/resonite/semantic-baselines/type-dem-grid-projection-result/baseline-parent/higashi-53395325-dem-bldg-grid-geotiff.jsonshowed the existing parent-stack dedicated-material delta (96 +75/-21), with no new texture-payload-shaped regression. The generated dump was deleted and is not committed.Review Gate