Skip to content

Type Resonite texture payload variants#354

Closed
esnya wants to merge 1 commit into
codex/type-texture-payload-variantsfrom
codex/type-resonite-texture-payload-variants
Closed

Type Resonite texture payload variants#354
esnya wants to merge 1 commit into
codex/type-texture-payload-variantsfrom
codex/type-resonite-texture-payload-variants

Conversation

@esnya
Copy link
Copy Markdown
Owner

@esnya esnya commented Jun 2, 2026

Summary

  • Split target-internal ResoniteTexturePayload into RawRgba32ResoniteTexturePayload and EncodedImageResoniteTexturePayload so raw payload dimensions and bytes are available without nullable fallback.
  • Removed ResoniteTexturePayloadFormat and switched target/test adapters to concrete payload pattern matching.
  • Removed the remaining null-forgiving encoded-source handoff in the neutral texture contract and target payload constructors.

Notes

  • The target payload variants are classes rather than records so the hierarchy stays closed by private protected construction without record copy-constructor escape, and so existing reference-identity behavior stays unchanged.
  • This is not a same-shape wrapper split: raw payloads carry non-null Width, Height, and BinaryPayload; encoded payloads carry an import source and optional metadata dimensions.

Verification

  • dotnet restore PlateauResoniteLink.sln --locked-mode --disable-build-servers
  • dotnet format whitespace . --folder --verify-no-changes
  • dotnet build PlateauResoniteLink.sln --configuration Release --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=false
  • dotnet test PlateauResoniteLink.sln --configuration Release --no-restore --verbosity normal -m:1 --disable-build-servers -p:UseSharedCompilation=false (1021 passed)
  • Fake Live Sink canonical dump for plateau-13213-higashimurayama-shi-2020 / 53395325 / dem,bldg / grid completed. git diff --no-index against runtime/windows/resonite/semantic-baselines/type-dem-grid-projection-result/baseline-parent/higashi-53395325-dem-bldg-grid-geotiff.json showed the existing parent-stack dedicated-material delta (96 +75/-21), with no new texture-payload-shaped regression. The generated dump was deleted and is not committed.

Review Gate

@esnya esnya force-pushed the codex/type-texture-payload-variants branch from 1ea3d1f to 0f8edcf Compare June 2, 2026 17:13
@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch from 8db6f10 to c1b43cc Compare June 2, 2026 17:23
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from 0f8edcf to c601f6e Compare June 2, 2026 18:24
@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch from c1b43cc to 1688d2c Compare June 2, 2026 18:24
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from c601f6e to 5410aa3 Compare June 2, 2026 19:16
@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch from 1688d2c to 4188c2c Compare June 2, 2026 19:16
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from 5410aa3 to 609699a Compare June 2, 2026 19:34
@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch from 4188c2c to 42a903f Compare June 2, 2026 19:34
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from 609699a to c34effc Compare June 2, 2026 19:59
@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch from 42a903f to 7de5429 Compare June 2, 2026 19:59
@esnya esnya force-pushed the codex/type-texture-payload-variants branch from c34effc to a2d73c6 Compare June 2, 2026 20:48
@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch from 7de5429 to c9809de Compare June 2, 2026 20:48
@esnya
Copy link
Copy Markdown
Owner Author

esnya commented Jun 2, 2026

Superseded by #340: these texture source/payload changes depend on the same upstream texture boundary and have been folded into the main-target #340 PR instead of keeping a dependent stack.

@esnya esnya closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant