Use texture source as payload identity carrier#355
Conversation
8db6f10 to
c1b43cc
Compare
f732db6 to
f14bb72
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f14bb72612
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f14bb72 to
6c64772
Compare
6c64772 to
168eee8
Compare
1688d2c to
4188c2c
Compare
168eee8 to
4e7929b
Compare
4188c2c to
42a903f
Compare
4e7929b to
b16e1a8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b16e1a8582
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
42a903f to
7de5429
Compare
b16e1a8 to
7af0bec
Compare
7de5429 to
c9809de
Compare
7af0bec to
0295adc
Compare
Summary
Identity/ColorProfilecarriers from neutral and Resonite texture payloads.ITextureImportSource.Identity/ITextureImportSource.ColorProfileas the single source of truth for grouping, mapping, and test assertions.Why
This keeps texture identity at the upstream import-source boundary instead of duplicating the same value on payload wrappers. Raw payload constructors still accept an identity only because they create the in-memory source at that boundary; after construction, the source is the only carrier.
Verification
dotnet restore PlateauResoniteLink.sln --locked-mode --disable-build-serversdotnet format whitespace . --folder --verify-no-changesdotnet build PlateauResoniteLink.sln --configuration Release --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=falsedotnet test PlateauResoniteLink.sln --configuration Release --no-restore --verbosity normal -m:1 --disable-build-servers -p:UseSharedCompilation=false(1023 passed)plateau-13213-higashimurayama-shi-2020/53395325/dem,bldg/gridcompleted.git diff --no-indexagainstruntime/windows/resonite/semantic-baselines/type-dem-grid-projection-result/baseline-parent/higashi-53395325-dem-bldg-grid-geotiff.jsonshowed the existing parent-stack dedicated-material delta (96 +75/-21), with no new texture-source identity shaped regression. The generated dump was deleted and is not committed.Review Gate