Skip to content

Use texture source as payload identity carrier#355

Closed
esnya wants to merge 1 commit into
codex/type-resonite-texture-payload-variantsfrom
codex/type-texture-source-identity-carrier
Closed

Use texture source as payload identity carrier#355
esnya wants to merge 1 commit into
codex/type-resonite-texture-payload-variantsfrom
codex/type-texture-source-identity-carrier

Conversation

@esnya
Copy link
Copy Markdown
Owner

@esnya esnya commented Jun 2, 2026

Summary

  • Remove duplicated Identity / ColorProfile carriers from neutral and Resonite texture payloads.
  • Use ITextureImportSource.Identity / ITextureImportSource.ColorProfile as the single source of truth for grouping, mapping, and test assertions.
  • Remove encoded payload identity/color-profile override parameters so encoded payloads cannot disagree with their import source.

Why

This keeps texture identity at the upstream import-source boundary instead of duplicating the same value on payload wrappers. Raw payload constructors still accept an identity only because they create the in-memory source at that boundary; after construction, the source is the only carrier.

Verification

  • dotnet restore PlateauResoniteLink.sln --locked-mode --disable-build-servers
  • dotnet format whitespace . --folder --verify-no-changes
  • dotnet build PlateauResoniteLink.sln --configuration Release --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=false
  • dotnet test PlateauResoniteLink.sln --configuration Release --no-restore --verbosity normal -m:1 --disable-build-servers -p:UseSharedCompilation=false (1023 passed)
  • Fake Live Sink canonical dump for plateau-13213-higashimurayama-shi-2020 / 53395325 / dem,bldg / grid completed. git diff --no-index against runtime/windows/resonite/semantic-baselines/type-dem-grid-projection-result/baseline-parent/higashi-53395325-dem-bldg-grid-geotiff.json showed the existing parent-stack dedicated-material delta (96 +75/-21), with no new texture-source identity shaped regression. The generated dump was deleted and is not committed.

Review Gate

  • Base PR Type Resonite texture payload variants #354 is CLEAN, CI green, has PR-body THUMBS_UP, and has no review threads.
  • Open PR merge states were rechecked before push; all listed open PRs were CLEAN.
  • Explorer subagent launch was attempted for fresh local review but the thread limit was reached, so the main agent performed the scoped review.

@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch from 8db6f10 to c1b43cc Compare June 2, 2026 17:23
@esnya esnya force-pushed the codex/type-texture-source-identity-carrier branch from f732db6 to f14bb72 Compare June 2, 2026 17:35
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f14bb72612

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/PlateauResoniteLink/Application/Importing/SceneImportContractTypes.cs Outdated
@esnya esnya force-pushed the codex/type-texture-source-identity-carrier branch from f14bb72 to 6c64772 Compare June 2, 2026 17:54
@esnya esnya force-pushed the codex/type-texture-source-identity-carrier branch from 6c64772 to 168eee8 Compare June 2, 2026 18:24
@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch 2 times, most recently from 1688d2c to 4188c2c Compare June 2, 2026 19:16
@esnya esnya force-pushed the codex/type-texture-source-identity-carrier branch from 168eee8 to 4e7929b Compare June 2, 2026 19:16
@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch from 4188c2c to 42a903f Compare June 2, 2026 19:34
@esnya esnya force-pushed the codex/type-texture-source-identity-carrier branch from 4e7929b to b16e1a8 Compare June 2, 2026 19:34
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b16e1a8582

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/PlateauResoniteLink/Targets/Resonite/ResoniteTexturePayload.cs
@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch from 42a903f to 7de5429 Compare June 2, 2026 19:59
@esnya esnya force-pushed the codex/type-texture-source-identity-carrier branch from b16e1a8 to 7af0bec Compare June 2, 2026 19:59
@esnya esnya force-pushed the codex/type-resonite-texture-payload-variants branch from 7de5429 to c9809de Compare June 2, 2026 20:48
@esnya esnya force-pushed the codex/type-texture-source-identity-carrier branch from 7af0bec to 0295adc Compare June 2, 2026 20:48
@esnya
Copy link
Copy Markdown
Owner Author

esnya commented Jun 2, 2026

Superseded by #340: these texture source/payload changes depend on the same upstream texture boundary and have been folded into the main-target #340 PR instead of keeping a dependent stack.

@esnya esnya closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant