Fix failing accountService test + add PR CI workflow#21
Merged
Conversation
…dd PR test workflow Agent-Logs-Url: https://github.com/esoadamo/cloudflare-oidc-proxy/sessions/e9ce0f1a-7740-49c3-a0c7-8502690cf4cf Co-authored-by: esoadamo <15877754+esoadamo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/esoadamo/cloudflare-oidc-proxy/sessions/e9ce0f1a-7740-49c3-a0c7-8502690cf4cf Co-authored-by: esoadamo <15877754+esoadamo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findByLoginfailed to resolveemail@example.combecause the exampleACCOUNT_MAPonly listed aliased emails (email.A@,email.B@), not the account's own email. There was also a logic bug where execution fell through tothrowafterresolve().Changes
config/accounts.example.js— Addedemail@example.comtoACCOUNT_MAP["account1"]so the account's primary email is a valid login mappingutil/accountService.js— Addedreturnbeforeresolve()infindByLoginto stop loop fall-through to thethrow.github/workflows/test.yml— New workflow runningnpm teston every PR withpermissions: contents: read