Merge pull request #5 from esp/removeModelUpdates

0.0.14

Author: KeithWoods

package.json

@@ -1,6 +1,6 @@
 {
   "name": "esp-js-devtools",
-  "version": "0.0.13",
+  "version": "0.0.14",
   "description": "Evented State Processor (ESP) dev tools",
   "main": "dist/esp-js-devtools.js",
   "scripts": {
@@ -13,7 +13,7 @@
   "repository": "https://github.com/esp/esp-js",
   "dependencies": {
     "babel-plugin-transform-runtime": "^6.4.3",
-    "esp-js": "^0.5.15",
+    "esp-js": "^0.5.16",
     "install": "^0.4.2",
     "jquery": "^2.2.0",
     "jquery-ui": "^1.10.5",

qq

@@ -0,0 +1,30 @@
+diff --git a/src/devtoolsHooks.js b/src/devtoolsHooks.js
+index 5543b0f..773aaaf 100644
+--- a/src/devtoolsHooks.js
++++ b/src/devtoolsHooks.js
+@@ -53,13 +53,18 @@ class Controller {
+     }
+     tryOpenDevTools() {
+         if(this._view === null) {
+-            this._view = new DevToolsView(DevToolsModel.modelId, this._router);
+-            this._view.start();
+-            this._view.addDisposable(
+-                () => {
+-                    this._view = null;
+-                }
+-            );
++            try {
++                this._view = new DevToolsView(DevToolsModel.modelId, this._router);
++                this._view.start();
++                this._view.addDisposable(
++                    () => {
++                        this._view = null;
++                    }
++                );
++            } catch (err) {
++                alert(`Error opening dev tools ${err}`);
++            }
++
+         }
+     }
+ }

src/devtoolsHooks.js

@@ -53,13 +53,18 @@ class Controller {
     }
     tryOpenDevTools() {
         if(this._view === null) {
-            this._view = new DevToolsView(DevToolsModel.modelId, this._router);
-            this._view.start();
-            this._view.addDisposable(
-                () => {
-                    this._view = null;
-                }
-            );
+            try {
+                this._view = new DevToolsView(DevToolsModel.modelId, this._router);
+                this._view.start();
+                this._view.addDisposable(
+                    () => {
+                        this._view = null;
+                    }
+                );
+            } catch (err) {
+                alert(`Error opening dev tools ${err}`);
+            }
+
         }
     }
 }

src/model/analyticsMonitor.js

@@ -27,6 +27,10 @@ export default class AnalyticsMonitor {
         if(modelId === DebugToolsModel.modelId) return;
         this._router.publishEvent(this._devToolsModelId, 'modelAdded', {modelId: modelId});
     }
+    removeModel(modelId) {
+        if(modelId === DebugToolsModel.modelId) return;
+        this._router.publishEvent(this._devToolsModelId, 'modelRemoved', {modelId: modelId});
+    }
     publishEvent(modelId, eventType, event) {
         if(modelId === DebugToolsModel.modelId) return;
         this._router.publishEvent(this._devToolsModelId,'eventPublished', {modelId: modelId, eventType: eventType, event:event});

src/model/devToolsModel.js

@@ -67,6 +67,9 @@ export default class DevToolsModel extends esp.model.DisposableBase {
     get shouldAutoScroll() {
         return this._shouldAutoScroll;
     }
+    get shouldLogToConsole() {
+        return this._shouldLogToConsole;
+    }
     get dataPointsIdsToRemove() {
         return this._dataPointsIdsToRemove;
     }

src/views/devToolsView.js

@@ -99,6 +99,9 @@ export default class DevToolsView extends esp.model.DisposableBase {
                         if (this._autoscrollCheckbox.prop('checked') !== model.shouldAutoScroll) {
                             this._autoscrollCheckbox.prop('checked', model.shouldAutoScroll);
                         }
+                        if (this._logEventsConsoleCheckbox.prop('checked') !== model.shouldLogToConsole) {
+                            this._logEventsConsoleCheckbox.prop('checked', model.shouldLogToConsole);
+                        }
                         if (this._eventDetailsDescriptionP && model.selectedDataPoint) {
                             this._eventDetailsDescriptionP.html(JSON.stringify(model.selectedDataPoint));
                         }

src/views/devToolsView.less

@@ -15,6 +15,13 @@ div#esp-js-devtool-container {
     color: #5F5F5F;
   }
 
+  // hide vertical lines and corrosponding dots on the timeline.
+  // we could use a 'type' of 'point', however that seems to be styled to allow a label which we don't use
+  .vis-line, .vis-dot {
+    display: none;
+  }
+
+
   a:link, a:hover, a:visited, a:active {
     text-decoration: none;
     font-size: 16px;