Add extra hdlc_landis_gyr_e450_cyprus packet dump#15
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new HDLC “long packet” test fixture (raw dump plus decoded outputs) intended to exercise General Block Transfer reassembly and subsequent DATA-NOTIFICATION / AXDR decoding for a Landis+Gyr E450 Cyprus capture.
Changes:
- Added a new raw HDLC dump for
hdlc_landis_gyr_e450_cyprus_long_packet. - Added expected decoded XML for the dump.
- Added a human-readable decoded trace log for the dump.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/dumps/hdlc_landis_gyr_e450_cyprus_long_packet.log | Adds the raw HDLC byte stream fixture for a longer multi-frame capture. |
| tests/dumps/hdlc_landis_gyr_e450_cyprus_long_packet_decoded.xml | Adds the expected decoded XML (DATA-NOTIFICATION payload). |
| tests/dumps/hdlc_landis_gyr_e450_cyprus_long_packet_decoded.log | Adds the expected step-by-step decoded trace for frames/APDUs/AXDR. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PolarGoose
force-pushed
the
fix_hdlc_landis_gyr_e450_cyprus_long_packet
branch
from
July 4, 2026 12:08
6587418 to
18faff5
Compare
PolarGoose
changed the title
hdlc_landis_gyr_e450_cyprus_long_packet workhdlc_landis_gyr_e450_cyprus packet dump
PolarGoose
changed the title
hdlc_landis_gyr_e450_cyprus packet dumphdlc_landis_gyr_e450_cyprus packet dump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hdlc_landis_gyr_e450_cyprussends two different packets. We only added one to our dumps. This is another one that the meter sends only once per 20 full transmissions.