Skip the MBus short frame at the beginning of the buffer.#18
Merged
Conversation
PolarGoose
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #16 by making the DLMS parser tolerate an M-Bus short frame prefix that some meters prepend to otherwise normal HDLC payloads, preventing spurious “invalid frame” / “no objects found” errors.
Changes:
- Detect an M-Bus short frame at the beginning of the input buffer and skip its 5-byte prefix before transport auto-detection/decoding.
- Add an integration test case that prepends
0x10 .. 0x16(valid short frame) to an existing segmented HDLC dump to ensure parsing still succeeds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/dlms_parser/dlms_parser.cpp |
Adds M-Bus short-frame prefix detection and strips it before HDLC/M-Bus/RAW decoding. |
tests/test_meter_dumps.cpp |
Adds a regression test for an HDLC dump with a leading M-Bus short frame prefix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PolarGoose
force-pushed
the
skip_mbus_short_frame
branch
from
July 12, 2026 20:31
7aa37e3 to
6b93a92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16