Re-export COMPONENT_TYPE_TO_INFO from the top-level package#1765
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 4183 4183
=========================================
Hits 4183 4183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughCOMPONENT_TYPE_TO_INFO is added to the public API export list in ChangesPublic API Export
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this implement/fix?
COMPONENT_TYPE_TO_INFOis part of the public API; Home Assistant'sesphome/entry_data.pyimports it from the top-level package. PR #1749 added__all__tomodel.pyto stop leaking stdlib names, butCOMPONENT_TYPE_TO_INFOwas treated as internal and left out, sofrom aioesphomeapi import COMPONENT_TYPE_TO_INFOstarted failing in 45.3.0. This adds it back to__all__, removes it from the_NOT_EXPORTEDset in the public API test, and pins it viatest_representative_model_classes_stay_exported.Types of changes
Related issue or feature (if applicable):
Pull request in esphome (if applicable):
Checklist:
tests/folder).