[emontx] Update UART RX/TX pins to GPIO20/GPIO21 for emonWifi#6567
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughDocumentation updates to the EmonTx component hub guide: two UART configuration examples now specify GPIO20 and GPIO21 instead of GPIO16 and GPIO17 for UART RX and TX pins respectively. ChangesDocumentation: EmonTx UART GPIO Pin Corrections
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
…e#6567) Co-authored-by: Frédéric Metrich <frederic.metrich@siemens.com>
Description
Update the UART pin assignments in all sample YAML configurations from GPIO16 (RX) / GPIO17 (TX) to GPIO20 (RX) / GPIO21 (TX), which are the pins used on the emonWifi expansion board.
Related issue (if applicable): N/A
Pull request in esphome with YAML changes (if applicable):
Checklist
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/src/content/docs/components/index.mdxwhen creating new documents for new components or cookbook.